From c63307e6d7602cab5109059cac2f41557cdb93e7 Mon Sep 17 00:00:00 2001 From: Sanchayan Maity Date: Tue, 18 Oct 2022 15:34:37 +0530 Subject: [PATCH] net/webrtc-http: whipsink: Return a proper error message & not panic On a server error, we currently crash and panic. Return a proper error message instead. Part-of: --- net/webrtc-http/src/whipsink/imp.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/webrtc-http/src/whipsink/imp.rs b/net/webrtc-http/src/whipsink/imp.rs index 90d55ac6..fe5e40f1 100644 --- a/net/webrtc-http/src/whipsink/imp.rs +++ b/net/webrtc-http/src/whipsink/imp.rs @@ -682,7 +682,10 @@ impl WhipSink { s if s.is_server_error() => { // FIXME: Check and handle 'Retry-After' header in case of server error - todo!() + Err(gst::error_msg!( + gst::ResourceError::Failed, + ["Server returned error: {}", s.as_str()] + )) } s => Err(gst::error_msg!(