From a10577b42cb47d69be763ffb0e105eaa7eec629b Mon Sep 17 00:00:00 2001
From: Guillaume Desmottes <guillaume.desmottes@onestream.live>
Date: Wed, 26 Jun 2024 09:51:45 +0200
Subject: [PATCH] aws: log error if sink failed to start

I find it confusing that the element was failing without reporting any
error in its logs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1638>
---
 net/aws/src/s3sink/multipartsink.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/aws/src/s3sink/multipartsink.rs b/net/aws/src/s3sink/multipartsink.rs
index 850c39af..24bca9f3 100644
--- a/net/aws/src/s3sink/multipartsink.rs
+++ b/net/aws/src/s3sink/multipartsink.rs
@@ -1028,7 +1028,12 @@ impl URIHandlerImpl for S3Sink {
 
 impl BaseSinkImpl for S3Sink {
     fn start(&self) -> Result<(), gst::ErrorMessage> {
-        self.start()
+        let res = self.start();
+        if let Err(ref err) = res {
+            gst::error!(CAT, imp: self, "Failed to start: {err}");
+        }
+
+        res
     }
 
     fn stop(&self) -> Result<(), gst::ErrorMessage> {