From 9ffcb146170e2709278599a64303632947fc6dc3 Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Wed, 25 Oct 2023 19:03:52 +0200 Subject: [PATCH] livesync: Remove the stop from outgoing segments Our buffer duplication can extend a segment indefinitely. Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/452 Part-of: --- utils/livesync/src/livesync/imp.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/utils/livesync/src/livesync/imp.rs b/utils/livesync/src/livesync/imp.rs index c5c821be..fa155689 100644 --- a/utils/livesync/src/livesync/imp.rs +++ b/utils/livesync/src/livesync/imp.rs @@ -1171,8 +1171,18 @@ impl LiveSync { state.out_duration = duration_from_caps(&caps); } - if let Some(segment) = segment { + if let Some(mut segment) = segment { if !state.single_segment { + if let Some(stop) = segment.stop() { + gst::debug!( + CAT, + imp: self, + "Removing stop {} from outgoing segment", + stop + ); + segment.set_stop(gst::ClockTime::NONE); + } + gst::debug!(CAT, imp: self, "Forwarding segment: {:?}", segment); let event = gst::event::Segment::new(&segment);