From 9e665ae80739382de3f65cb3e31eff2b67adc820 Mon Sep 17 00:00:00 2001 From: Mathieu Duponchelle Date: Wed, 4 Mar 2020 17:20:08 +0100 Subject: [PATCH] ts-jitterbuffer: fix request-pt-map emission When a new payload type is encountered, we first check whether it matches the caps received as an event before emitting the request-pt-map signal if not, which means we shouldn't consider errors from the first call to parse_caps as fatal. --- gst-plugin-threadshare/src/jitterbuffer/jitterbuffer.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gst-plugin-threadshare/src/jitterbuffer/jitterbuffer.rs b/gst-plugin-threadshare/src/jitterbuffer/jitterbuffer.rs index fea910e2..272ce066 100644 --- a/gst-plugin-threadshare/src/jitterbuffer/jitterbuffer.rs +++ b/gst-plugin-threadshare/src/jitterbuffer/jitterbuffer.rs @@ -665,7 +665,8 @@ impl JitterBuffer { gst_debug!(CAT, obj: pad, "New payload type: {}", pt); if let Some(caps) = pad.get_current_caps() { - self.parse_caps(state, element, &caps, pt)?; + /* Ignore errors at this point, as we want to emit request-pt-map */ + let _ = self.parse_caps(state, element, &caps, pt); } }