From 801d928aac4530f5914dded031cc6b5d3766fd37 Mon Sep 17 00:00:00 2001
From: Seungha Yang <seungha@centricular.com>
Date: Thu, 10 Mar 2022 20:10:30 +0900
Subject: [PATCH] transcriberbin: Don't notify signal inside lock

That can potentially cause deadlock
---
 video/closedcaption/src/transcriberbin/imp.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/video/closedcaption/src/transcriberbin/imp.rs b/video/closedcaption/src/transcriberbin/imp.rs
index 0942bbc4..9a4f0672 100644
--- a/video/closedcaption/src/transcriberbin/imp.rs
+++ b/video/closedcaption/src/transcriberbin/imp.rs
@@ -921,8 +921,8 @@ impl BinImpl for TranscriberBin {
                         drop(s);
                         let mut settings = self.settings.lock().unwrap();
                         settings.passthrough = true;
-                        bin.notify("passthrough");
                         drop(settings);
+                        bin.notify("passthrough");
                         bin.call_async(move |bin| {
                             let thiz = bin.imp();
                             thiz.block_and_update(bin, true);