From 7cf2736a158da637237d2a14403f65f3bb3dd615 Mon Sep 17 00:00:00 2001
From: Mathieu Duponchelle <mathieu@centricular.com>
Date: Thu, 24 Apr 2025 20:40:37 +0200
Subject: [PATCH] webrtcsink: call webrtcbin:add-ice-candidate without session
 lock

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2215>
---
 net/webrtc/src/webrtcsink/imp.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/webrtc/src/webrtcsink/imp.rs b/net/webrtc/src/webrtcsink/imp.rs
index 32fde80f1..6b11a27fa 100644
--- a/net/webrtc/src/webrtcsink/imp.rs
+++ b/net/webrtc/src/webrtcsink/imp.rs
@@ -3734,15 +3734,13 @@ impl BaseWebRTCSink {
         };
 
         if let Some(session) = state.sessions.get(session_id) {
-            let session = session.0.lock().unwrap();
+            let webrtcbin = session.0.lock().unwrap().webrtcbin.clone();
             gst::trace!(
                 CAT,
                 imp = self,
                 "adding ice candidate for session {session_id}"
             );
-            session
-                .webrtcbin
-                .emit_by_name::<()>("add-ice-candidate", &[&sdp_m_line_index, &candidate]);
+            webrtcbin.emit_by_name::<()>("add-ice-candidate", &[&sdp_m_line_index, &candidate]);
         } else {
             gst::warning!(CAT, imp = self, "No consumer with ID {session_id}");
         }