From 7b780e2aaf7947e945a22bc63aac2260c5651e49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mark-Andr=C3=A9=20Schadow?= Date: Tue, 18 Feb 2025 14:46:52 +0100 Subject: [PATCH] onvifmetadatacombiner: Metadata should not have a pts/dts Incoming onvif-data should be stripped of pts/dts, as they are not updated when attached to a frame. Pts/Dta are readded by the associated extractor element Linked to https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/655 Part-of: --- net/onvif/src/onvifmetadatacombiner/imp.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/onvif/src/onvifmetadatacombiner/imp.rs b/net/onvif/src/onvifmetadatacombiner/imp.rs index 2c6a3256c..4c4ebfd94 100644 --- a/net/onvif/src/onvifmetadatacombiner/imp.rs +++ b/net/onvif/src/onvifmetadatacombiner/imp.rs @@ -359,7 +359,12 @@ impl AggregatorImpl for OnvifMetadataCombiner { { let buflist_mut = buflist.get_mut().unwrap(); - for frame in state.meta_frames.drain(..) { + for mut frame in state.meta_frames.drain(..) { + { + let frame = frame.make_mut(); + frame.set_dts(None); + frame.set_pts(None); + } buflist_mut.add(frame); } }