From 7ac29827d2bf1cfa04a362e184def13cff89cc50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 3 Nov 2022 16:01:38 +0200 Subject: [PATCH] fmp4mux: Don't allow VP9 for CMAF This would require setting the correct compatible band for VP9 in CMAF, which is not implemented yet. --- mux/fmp4/src/fmp4mux/imp.rs | 8 -------- mux/fmp4/tests/tests.rs | 18 ------------------ 2 files changed, 26 deletions(-) diff --git a/mux/fmp4/src/fmp4mux/imp.rs b/mux/fmp4/src/fmp4mux/imp.rs index 56dcd8ad..b0eb3628 100644 --- a/mux/fmp4/src/fmp4mux/imp.rs +++ b/mux/fmp4/src/fmp4mux/imp.rs @@ -2458,14 +2458,6 @@ impl ElementImpl for CMAFMux { .field("width", gst::IntRange::new(1, u16::MAX as i32)) .field("height", gst::IntRange::new(1, u16::MAX as i32)) .build(), - gst::Structure::builder("video/x-vp9") - .field("profile", gst::List::new(["0", "1", "2", "3"])) - .field("chroma-format", gst::List::new(["4:2:0", "4:2:2", "4:4:4"])) - .field("bit-depth-luma", gst::List::new([8u32, 10u32, 12u32])) - .field("bit-depth-chroma", gst::List::new([8u32, 10u32, 12u32])) - .field("width", gst::IntRange::new(1, u16::MAX as i32)) - .field("height", gst::IntRange::new(1, u16::MAX as i32)) - .build(), gst::Structure::builder("audio/mpeg") .field("mpegversion", 4i32) .field("stream-format", "raw") diff --git a/mux/fmp4/tests/tests.rs b/mux/fmp4/tests/tests.rs index 45622d7a..5e10754a 100644 --- a/mux/fmp4/tests/tests.rs +++ b/mux/fmp4/tests/tests.rs @@ -187,24 +187,6 @@ fn test_buffer_flags_single_h264_stream_iso() { test_buffer_flags_single_stream(false, true, caps); } -#[test] -fn test_buffer_flags_single_vp9_stream_cmaf() { - init(); - - let caps = gst::Caps::builder("video/x-vp9") - .field("width", 1920i32) - .field("height", 1080i32) - .field("framerate", gst::Fraction::new(30, 1)) - .field("profile", "0") - .field("chroma-format", "4:2:0") - .field("bit-depth-luma", 8u32) - .field("bit-depth-chroma", 8u32) - .field("colorimetry", "bt709") - .build(); - - test_buffer_flags_single_stream(true, false, caps); -} - #[test] fn test_buffer_flags_single_vp9_stream_iso() { init();