From 61578518d42083fbac327cc946cf61fd8acb041a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Wed, 13 Aug 2025 13:57:35 +0300
Subject: [PATCH] transcriberbin: Fix settings/state lock order violation in
 set_property()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2463>
---
 video/closedcaption/src/transcriberbin/imp.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/video/closedcaption/src/transcriberbin/imp.rs b/video/closedcaption/src/transcriberbin/imp.rs
index cd18e83e8..3b9d8500d 100644
--- a/video/closedcaption/src/transcriberbin/imp.rs
+++ b/video/closedcaption/src/transcriberbin/imp.rs
@@ -2601,10 +2601,10 @@ impl ObjectImpl for TranscriberBin {
                 settings.cc_caps = value.get().expect("type checked upstream");
             }
             "caption-source" => {
+                let s = self.state.lock().unwrap();
                 let mut settings = self.settings.lock().unwrap();
                 settings.caption_source = value.get().expect("type checked upstream");
 
-                let s = self.state.lock().unwrap();
                 if let Some(state) = s.as_ref() {
                     if state.cccombiner.has_property("input-meta-processing") {
                         match settings.caption_source {