From 570eb7463a3bddea1e30370f09a30da1e4bf3131 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Mon, 16 Jan 2023 16:42:56 +0100 Subject: [PATCH] livesync: fix late-threshold property min value The code is handling 0 as "always over threshold" but it was not possible to set the property to 0. Part-of: --- docs/plugins/gst_plugins_cache.json | 2 +- utils/livesync/src/livesync/imp.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/plugins/gst_plugins_cache.json b/docs/plugins/gst_plugins_cache.json index dbfcd7ed..8a72cd28 100644 --- a/docs/plugins/gst_plugins_cache.json +++ b/docs/plugins/gst_plugins_cache.json @@ -2587,7 +2587,7 @@ "controllable": false, "default": "2000000000", "max": "18446744073709551615", - "min": "1000000000", + "min": "0", "mutable": "playing", "readable": true, "type": "guint64", diff --git a/utils/livesync/src/livesync/imp.rs b/utils/livesync/src/livesync/imp.rs index 63c15678..0840334f 100644 --- a/utils/livesync/src/livesync/imp.rs +++ b/utils/livesync/src/livesync/imp.rs @@ -103,7 +103,7 @@ const PROP_SINGLE_SEGMENT: &str = "single-segment"; const DEFAULT_LATENCY: gst::ClockTime = gst::ClockTime::ZERO; const DEFAULT_DURATION: gst::ClockTime = gst::ClockTime::from_mseconds(100); -const MINIMUM_LATE_THRESHOLD: gst::ClockTime = gst::ClockTime::from_seconds(1); +const MINIMUM_LATE_THRESHOLD: gst::ClockTime = gst::ClockTime::ZERO; const DEFAULT_LATE_THRESHOLD: Option = Some(gst::ClockTime::from_seconds(2)); impl Default for State {