From 1faef49b51746a82c5b99a09a1034220cf92af9d Mon Sep 17 00:00:00 2001
From: Arun Raghavan <arun@asymptotic.io>
Date: Thu, 14 Dec 2023 11:25:51 -0500
Subject: [PATCH] threadshare: Fix a deadlock in used-socket notification

This manifests in a gst-launch-1.0 pipeline using ts-udpsrc, since
notification of used-socket results in the property being read by the
application, and the settings lock causes a deadlock.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1408>
---
 generic/threadshare/src/udpsrc/imp.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/generic/threadshare/src/udpsrc/imp.rs b/generic/threadshare/src/udpsrc/imp.rs
index 997ca1f3..39bc9fbb 100644
--- a/generic/threadshare/src/udpsrc/imp.rs
+++ b/generic/threadshare/src/udpsrc/imp.rs
@@ -375,6 +375,8 @@ impl TaskImpl for UdpSrcTask {
                 )
             })?;
 
+            drop(settings);
+
             self.socket = Some(
                 Socket::try_new(
                     self.element.clone().upcast(),