From 0cf169aa20c95a761b14badb11645cfd1ae841bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 10 Apr 2017 20:00:22 +0300 Subject: [PATCH] Fix some clippy warnings --- gst-plugin/src/caps.rs | 2 +- gst-plugin/src/sink.rs | 5 ++++- gst-plugin/src/source.rs | 5 ++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gst-plugin/src/caps.rs b/gst-plugin/src/caps.rs index 10827e78..cf2b4c59 100644 --- a/gst-plugin/src/caps.rs +++ b/gst-plugin/src/caps.rs @@ -78,7 +78,7 @@ impl Caps { let name_cstr = CString::new(value.0).unwrap(); unsafe { let mut gvalue = value.1.to_gvalue(); - gst::gst_caps_set_value(self.0, name_cstr.as_ptr(), &mut gvalue); + gst::gst_caps_set_value(self.0, name_cstr.as_ptr(), &gvalue); gobject::g_value_unset(&mut gvalue); } } diff --git a/gst-plugin/src/sink.rs b/gst-plugin/src/sink.rs index c1945f78..2a4afddf 100644 --- a/gst-plugin/src/sink.rs +++ b/gst-plugin/src/sink.rs @@ -237,7 +237,10 @@ unsafe fn sink_get_uri(ptr: *const RsSink) -> *mut c_char { panic_to_error!(wrap, ptr::null_mut(), { match wrap.get_uri() { - Some(uri_str) => glib::g_strdup(CString::new(uri_str).unwrap().as_ptr()), + Some(uri_str) => { + let uri_cstr = CString::new(uri_str).unwrap(); + glib::g_strdup(uri_cstr.as_ptr()) + } None => ptr::null_mut(), } }) diff --git a/gst-plugin/src/source.rs b/gst-plugin/src/source.rs index 41705bda..5d01fb16 100644 --- a/gst-plugin/src/source.rs +++ b/gst-plugin/src/source.rs @@ -269,7 +269,10 @@ unsafe fn source_get_uri(ptr: *const RsSrc) -> *mut c_char { panic_to_error!(wrap, ptr::null_mut(), { match wrap.get_uri() { - Some(uri_str) => glib::g_strdup(CString::new(uri_str).unwrap().as_ptr()), + Some(uri_str) => { + let uri_cstr = CString::new(uri_str).unwrap(); + glib::g_strdup(uri_cstr.as_ptr()) + } None => ptr::null_mut(), } })