From 084c9d1447614fe5352c0106e9a1a9e1bb6af6e7 Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Mon, 18 Jan 2021 23:55:20 +0900 Subject: [PATCH] fallbackswitch,togglerecord: Don't apply clipped PTS to buffer DTS Setting DTS on raw video buffers doesn't make sense and it's even wrong in case of compressed video stream because PTS might be able to go back when B frames are placed, but DTS is expected to be monotonically increased. --- utils/fallbackswitch/src/fallbackswitch/imp.rs | 1 - utils/togglerecord/src/togglerecord/imp.rs | 1 - 2 files changed, 2 deletions(-) diff --git a/utils/fallbackswitch/src/fallbackswitch/imp.rs b/utils/fallbackswitch/src/fallbackswitch/imp.rs index 082a8269..93a12570 100644 --- a/utils/fallbackswitch/src/fallbackswitch/imp.rs +++ b/utils/fallbackswitch/src/fallbackswitch/imp.rs @@ -1128,7 +1128,6 @@ impl AggregatorImpl for FallbackSwitch { { let buffer = buffer.make_mut(); buffer.set_pts(start); - buffer.set_dts(start); if duration.is_some() { buffer.set_duration(stop - start); } diff --git a/utils/togglerecord/src/togglerecord/imp.rs b/utils/togglerecord/src/togglerecord/imp.rs index 7ca671ca..e6140648 100644 --- a/utils/togglerecord/src/togglerecord/imp.rs +++ b/utils/togglerecord/src/togglerecord/imp.rs @@ -336,7 +336,6 @@ impl HandleData for gst::Buffer { { let buffer = self.make_mut(); buffer.set_pts(start); - buffer.set_dts(start); buffer.set_duration(stop - start); }