From 65b53660313f0faaa5d0bbb53ddcdb8ff23559d2 Mon Sep 17 00:00:00 2001 From: tobi <31960611+tsmethurst@users.noreply.github.com> Date: Tue, 2 Apr 2024 14:40:54 +0200 Subject: [PATCH] [bugfix] Set domain for empty-domain Friendica accounts (#2800) --- .../20240402113305_nil_domain_fix.go | 86 +++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 internal/db/bundb/migrations/20240402113305_nil_domain_fix.go diff --git a/internal/db/bundb/migrations/20240402113305_nil_domain_fix.go b/internal/db/bundb/migrations/20240402113305_nil_domain_fix.go new file mode 100644 index 000000000..c1adcb1fb --- /dev/null +++ b/internal/db/bundb/migrations/20240402113305_nil_domain_fix.go @@ -0,0 +1,86 @@ +// GoToSocial +// Copyright (C) GoToSocial Authors admin@gotosocial.org +// SPDX-License-Identifier: AGPL-3.0-or-later +// +// This program is free software: you can redistribute it and/or modify +// it under the terms of the GNU Affero General Public License as published by +// the Free Software Foundation, either version 3 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU Affero General Public License for more details. +// +// You should have received a copy of the GNU Affero General Public License +// along with this program. If not, see . + +package migrations + +import ( + "context" + "net/url" + + "github.com/uptrace/bun" +) + +func init() { + up := func(ctx context.Context, db *bun.DB) error { + return db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error { + // Select URI of each friendica account + // with an empty domain that doesn't have + // a corresponding user (ie., not local). + // Query looks like: + // + // SELECT "uri" FROM "accounts" + // WHERE ("username" = 'friendica') + // AND ("actor_type" = 'Application') + // AND ("domain" IS NULL) + // AND ("id" NOT IN (SELECT "account_id" FROM "users")) + URIStrs := []string{} + if err := tx. + NewSelect(). + Table("accounts"). + Column("uri"). + Where("? = ?", bun.Ident("username"), "friendica"). + Where("? = ?", bun.Ident("actor_type"), "Application"). + Where("? IS NULL", bun.Ident("domain")). + Where("? NOT IN (?)", bun.Ident("id"), tx.NewSelect().Table("users").Column("account_id")). + Scan(ctx, &URIStrs); err != nil { + return err + } + + // For each URI found this way, parse + // out the Host part and update the + // domain of the domain-less account. + for _, uriStr := range URIStrs { + uri, err := url.Parse(uriStr) + if err != nil { + return err + } + + domain := uri.Host + if _, err := tx. + NewUpdate(). + Table("accounts"). + Set("? = ?", bun.Ident("domain"), domain). + Where("? = ?", bun.Ident("uri"), uriStr). + Exec(ctx); err != nil { + return err + } + } + + return nil + }) + } + + down := func(ctx context.Context, db *bun.DB) error { + return db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error { + return nil + }) + } + + if err := Migrations.Register(up, down); err != nil { + panic(err) + } +}