From dc39043cd6b6a66d53d58fbd82a538cd19c44d9a Mon Sep 17 00:00:00 2001 From: Gergely Nagy Date: Wed, 17 Apr 2024 11:04:48 +0200 Subject: [PATCH] Change the default SSH clone url to the ssh:// style Rather than using an scp-style URI, use the same URL style for SSH clones as for HTTP(S) ones. This is not only more consistent, but the URL style allows one to specify a port, and makes it clear that it is an SSH clone URL. git itself favours the URL style, and mentions the scp-style in passing only. Said style is prominently used by GitHub, and might be more familiar for a lot of people, but other than familiarity, it has no advantage over the URL style. For the benefit of consistency, and flexibility, lets flip the default, and make it the URL style. Instance admins who prefer to use the scp-style, and are running SSH on its standard port, can change the setting back to false. This addresses #3193. Signed-off-by: Gergely Nagy --- modules/setting/repository.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/setting/repository.go b/modules/setting/repository.go index 50f0fd704c..6086dd1d57 100644 --- a/modules/setting/repository.go +++ b/modules/setting/repository.go @@ -162,7 +162,7 @@ var ( PreferredLicenses: []string{"Apache-2.0", "MIT"}, DisableHTTPGit: false, AccessControlAllowOrigin: "", - UseCompatSSHURI: false, + UseCompatSSHURI: true, DefaultCloseIssuesViaCommitsInAnyBranch: false, EnablePushCreateUser: false, EnablePushCreateOrg: false,