From 6e82d0bb7c1feb04ac004dd587ce83c2ee609917 Mon Sep 17 00:00:00 2001 From: Giteabot Date: Mon, 17 Jul 2023 05:44:10 -0400 Subject: [PATCH] Add shutting down notice (#25920) (#25922) Backport #25920 by @KN4CK3R Got the same problem as #25915 when updating an instance. The `log.Fatal` should have been marked as breaking in #23911. This PR adds a notice that the system is shutting down because of the deprecated setting. Co-authored-by: KN4CK3R --- modules/setting/config_provider.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/setting/config_provider.go b/modules/setting/config_provider.go index 94dd989850..86712792a7 100644 --- a/modules/setting/config_provider.go +++ b/modules/setting/config_provider.go @@ -324,7 +324,7 @@ func deprecatedSetting(rootCfg ConfigProvider, oldSection, oldKey, newSection, n func deprecatedSettingFatal(rootCfg ConfigProvider, oldSection, oldKey, newSection, newKey, version string) { if rootCfg.Section(oldSection).HasKey(oldKey) { - log.Fatal("Deprecated fallback `[%s]` `%s` present. Use `[%s]` `%s` instead. This fallback will be/has been removed in %s", oldSection, oldKey, newSection, newKey, version) + log.Fatal("Deprecated fallback `[%s]` `%s` present. Use `[%s]` `%s` instead. This fallback will be/has been removed in %s. Shutting down", oldSection, oldKey, newSection, newKey, version) } }