From 1c523e212913cdb6fc2b0709af7f4c910d1728c8 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 9 Oct 2020 09:32:30 +0200 Subject: [PATCH] Set appropriate `autocomplete` attributes on password fields (#13078) `new-password` prevents annoying autocompletion in some cases, thought it's not semantically correct to use that for example on all three fields on the user account page, so some annoyances remain. Co-authored-by: Lauris BH --- templates/admin/auth/source/ldap.tmpl | 2 +- templates/admin/user/edit.tmpl | 2 +- templates/admin/user/new.tmpl | 2 +- templates/install.tmpl | 4 ++-- templates/org/settings/delete.tmpl | 2 +- templates/repo/settings/options.tmpl | 2 +- templates/user/auth/change_passwd_inner.tmpl | 4 ++-- templates/user/auth/reset_passwd.tmpl | 2 +- templates/user/auth/signin_inner.tmpl | 2 +- templates/user/auth/signup_inner.tmpl | 4 ++-- templates/user/settings/account.tmpl | 8 ++++---- 11 files changed, 17 insertions(+), 17 deletions(-) diff --git a/templates/admin/auth/source/ldap.tmpl b/templates/admin/auth/source/ldap.tmpl index 651877b1f7..6feb202abb 100644 --- a/templates/admin/auth/source/ldap.tmpl +++ b/templates/admin/auth/source/ldap.tmpl @@ -27,7 +27,7 @@
- +

{{.i18n.Tr "admin.auths.bind_password_helper"}}

diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl index 042c09954a..95323a97b2 100644 --- a/templates/admin/user/edit.tmpl +++ b/templates/admin/user/edit.tmpl @@ -43,7 +43,7 @@
- +

{{.i18n.Tr "admin.users.password_helper"}}

diff --git a/templates/admin/user/new.tmpl b/templates/admin/user/new.tmpl index 44cd0049b7..463374dab7 100644 --- a/templates/admin/user/new.tmpl +++ b/templates/admin/user/new.tmpl @@ -39,7 +39,7 @@
- +
diff --git a/templates/install.tmpl b/templates/install.tmpl index 6dc5e58e4f..27cf1034c5 100644 --- a/templates/install.tmpl +++ b/templates/install.tmpl @@ -284,11 +284,11 @@
- +
- +
diff --git a/templates/org/settings/delete.tmpl b/templates/org/settings/delete.tmpl index 2dd8fd8748..54d60f93f0 100644 --- a/templates/org/settings/delete.tmpl +++ b/templates/org/settings/delete.tmpl @@ -18,7 +18,7 @@
- +
{{.i18n.Tr "org.settings.confirm_delete_account"}} diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index f238b1b0ce..ce76a6fefa 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -107,7 +107,7 @@
- +
diff --git a/templates/user/auth/change_passwd_inner.tmpl b/templates/user/auth/change_passwd_inner.tmpl index 60d4a210ee..43818e93d2 100644 --- a/templates/user/auth/change_passwd_inner.tmpl +++ b/templates/user/auth/change_passwd_inner.tmpl @@ -9,13 +9,13 @@ {{.CsrfTokenHtml}}
- +
- +
diff --git a/templates/user/auth/reset_passwd.tmpl b/templates/user/auth/reset_passwd.tmpl index 91d5a5ef88..7d60fe4a86 100644 --- a/templates/user/auth/reset_passwd.tmpl +++ b/templates/user/auth/reset_passwd.tmpl @@ -19,7 +19,7 @@ {{if .IsResetForm}}
- +
{{if not .user_signed_in}}
diff --git a/templates/user/auth/signin_inner.tmpl b/templates/user/auth/signin_inner.tmpl index 9f6b3da05d..4d99d378ad 100644 --- a/templates/user/auth/signin_inner.tmpl +++ b/templates/user/auth/signin_inner.tmpl @@ -18,7 +18,7 @@ {{if or (not .DisablePassword) .LinkAccountMode}}
- +
{{end}} {{if not .LinkAccountMode}} diff --git a/templates/user/auth/signup_inner.tmpl b/templates/user/auth/signup_inner.tmpl index e52aa2e881..57dd22db4c 100644 --- a/templates/user/auth/signup_inner.tmpl +++ b/templates/user/auth/signup_inner.tmpl @@ -29,11 +29,11 @@ {{if not .DisablePassword}}
- +
- +
{{end}} {{if and .EnableCaptcha (eq .CaptchaType "image")}} diff --git a/templates/user/settings/account.tmpl b/templates/user/settings/account.tmpl index 530e42a1b4..113e03cd9b 100644 --- a/templates/user/settings/account.tmpl +++ b/templates/user/settings/account.tmpl @@ -13,16 +13,16 @@ {{if .SignedUser.IsPasswordSet}}
- +
{{end}}
- +
- +
@@ -179,7 +179,7 @@
- +