From f2cc43b55fc3eb91fc7c6e34cc3a68284d6d89c6 Mon Sep 17 00:00:00 2001 From: Lotte Steenbrink Date: Fri, 3 Jul 2020 14:49:54 +0200 Subject: [PATCH] re review. point to usb spec for wvalue etc --- advanced/common/usb/src/lib.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/advanced/common/usb/src/lib.rs b/advanced/common/usb/src/lib.rs index c66da16..498a54d 100644 --- a/advanced/common/usb/src/lib.rs +++ b/advanced/common/usb/src/lib.rs @@ -65,7 +65,9 @@ impl Request { if bmrequesttype == 0b00000000 && brequest == SET_ADDRESS { // Set the device address for all future accesses. - // Needed to successfully init when using Apple devices. + // (Needed to successfully init when conected to Apple devices) + // Section 9.4.6 Set Address of the USB specification explains which values for wvalue, + // windex and wlength are valid. if wvalue < 128 && windex == 0 && wlength == 0 { Ok(Request::SetAddress { address: NonZeroU8::new(wvalue as u8),