From 36c14655ecfd5b414c5b41be161a3d1e05437a1e Mon Sep 17 00:00:00 2001
From: Neil Roberts <bpeeluk@yahoo.co.uk>
Date: Thu, 6 Apr 2023 11:37:19 +0200
Subject: [PATCH 1/3] =?UTF-8?q?Use=20the=20translated=20shelf=20name=20in?=
 =?UTF-8?q?=20a=20book=E2=80=99s=20shelf=20list?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Previously in the list of shelves on the page for a book it was always
using the English name of the shelf for the shelf of the reading status.
---
 bookwyrm/templates/book/book.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bookwyrm/templates/book/book.html b/bookwyrm/templates/book/book.html
index e9eff99ab..1ebb3159e 100644
--- a/bookwyrm/templates/book/book.html
+++ b/bookwyrm/templates/book/book.html
@@ -4,6 +4,7 @@
 {% load humanize %}
 {% load utilities %}
 {% load static %}
+{% load shelf_tags %}
 
 {% block title %}{{ book|book_title }}{% endblock %}
 
@@ -239,7 +240,7 @@
                 <ul>
                 {% for shelf in user_shelfbooks %}
                     <li class="box">
-                        <a href="{{ shelf.shelf.local_path }}">{{ shelf.shelf.name }}</a>
+                        <a href="{{ shelf.shelf.local_path }}">{{ shelf.shelf|translate_shelf_name }}</a>
                         <div class="is-pulled-right">
                             {% include 'snippets/shelf_selector.html' with shelf=shelf.shelf class="is-small" readthrough=readthrough %}
                         </div>

From b0f90d05f24c997d326ce625c69337e383eeb8c8 Mon Sep 17 00:00:00 2001
From: Neil Roberts <bpeeluk@yahoo.co.uk>
Date: Thu, 6 Apr 2023 15:55:11 +0200
Subject: [PATCH 2/3] Move the shelf names to a dict instead of a chain of if
 statements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The main reason to do this is that if we try to add another name then
pylint will complain that there are too many return statements. It might
be slightly faster too.

If I understand correctly it doesn’t matter that the _ function is being
called at module load time because it is mapped to gettext_lazy so the
actual translation will be done when the string is used.
---
 bookwyrm/templatetags/shelf_tags.py | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/bookwyrm/templatetags/shelf_tags.py b/bookwyrm/templatetags/shelf_tags.py
index 1fb799883..ea093b8a5 100644
--- a/bookwyrm/templatetags/shelf_tags.py
+++ b/bookwyrm/templatetags/shelf_tags.py
@@ -9,6 +9,14 @@ from bookwyrm.utils import cache
 register = template.Library()
 
 
+SHELF_NAMES = {
+    "all": _("All books"),
+    "to-read": _("To Read"),
+    "reading": _("Currently Reading"),
+    "read": _("Read"),
+}
+
+
 @register.filter(name="is_book_on_shelf")
 def get_is_book_on_shelf(book, shelf):
     """is a book on a shelf"""
@@ -42,15 +50,11 @@ def get_translated_shelf_name(shelf):
         return ""
     # support obj or dict
     identifier = shelf["identifier"] if isinstance(shelf, dict) else shelf.identifier
-    if identifier == "all":
-        return _("All books")
-    if identifier == "to-read":
-        return _("To Read")
-    if identifier == "reading":
-        return _("Currently Reading")
-    if identifier == "read":
-        return _("Read")
-    return shelf["name"] if isinstance(shelf, dict) else shelf.name
+
+    try:
+        return SHELF_NAMES[identifier]
+    except KeyError:
+        return shelf["name"] if isinstance(shelf, dict) else shelf.name
 
 
 @register.simple_tag(takes_context=True)

From 9092c9c80c06154f3bd2394b68ca6599ea4ee4e6 Mon Sep 17 00:00:00 2001
From: Neil Roberts <bpeeluk@yahoo.co.uk>
Date: Thu, 6 Apr 2023 11:53:17 +0200
Subject: [PATCH 3/3] Add a translatable name for the "stopped-reading" status
 shelf

---
 bookwyrm/templatetags/shelf_tags.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bookwyrm/templatetags/shelf_tags.py b/bookwyrm/templatetags/shelf_tags.py
index ea093b8a5..6243fcae2 100644
--- a/bookwyrm/templatetags/shelf_tags.py
+++ b/bookwyrm/templatetags/shelf_tags.py
@@ -14,6 +14,7 @@ SHELF_NAMES = {
     "to-read": _("To Read"),
     "reading": _("Currently Reading"),
     "read": _("Read"),
+    "stopped-reading": _("Stopped Reading"),
 }