From fa79070b5978924388b47ecadaf65c952b0bf7b2 Mon Sep 17 00:00:00 2001 From: Fabien Basmaison Date: Sat, 20 Mar 2021 16:33:18 +0100 Subject: [PATCH] [lint] Update editorconfig linting: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add settings for comments. - Remove custom settings that don’t work. - Fix vendor JS file: --- .editorconfig | 5 +++++ .github/workflows/linters-global.yaml | 2 -- bookwyrm/static/js/tabs.js | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.editorconfig b/.editorconfig index 112b22d65..c03185f9a 100644 --- a/.editorconfig +++ b/.editorconfig @@ -12,6 +12,11 @@ indent_style = space insert_final_newline = true max_line_length = 100 +# C-style doc comments +block_comment_start = /* +block_comment = * +block_comment_end = */ + [{bw-dev,fr-dev,LICENSE}] max_line_length = off diff --git a/.github/workflows/linters-global.yaml b/.github/workflows/linters-global.yaml index 52abb12ce..291125c70 100644 --- a/.github/workflows/linters-global.yaml +++ b/.github/workflows/linters-global.yaml @@ -19,5 +19,3 @@ jobs: - name: EditorConfig uses: greut/eclint-action@v0 - with: - args: '-show_all_errors -exclude "bookwyrm/static/js/tabs.js"' diff --git a/bookwyrm/static/js/tabs.js b/bookwyrm/static/js/tabs.js index 1cb525ce9..59c072518 100644 --- a/bookwyrm/static/js/tabs.js +++ b/bookwyrm/static/js/tabs.js @@ -59,7 +59,9 @@ class TabGroup { } initPanels() { - let selectedPanelId = this.tablist.querySelector('[role="tab"][aria-selected="true"]').getAttribute("aria-controls"); + let selectedPanelId = this.tablist + .querySelector('[role="tab"][aria-selected="true"]') + .getAttribute("aria-controls"); for(let panel of this.panels) { if(panel.getAttribute("id") !== selectedPanelId) { panel.setAttribute("hidden", "");