From e0aa8a7fdf5fc046bc817410c1e65b6a4a880ea5 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Mon, 27 Sep 2021 17:58:21 -0700 Subject: [PATCH] Fixes shelf view boolean logic --- bookwyrm/tests/views/test_shelf.py | 2 +- bookwyrm/views/shelf.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bookwyrm/tests/views/test_shelf.py b/bookwyrm/tests/views/test_shelf.py index d873edc6a..0d7d01cbc 100644 --- a/bookwyrm/tests/views/test_shelf.py +++ b/bookwyrm/tests/views/test_shelf.py @@ -105,7 +105,7 @@ class ShelfViews(TestCase): shelf.refresh_from_db() self.assertEqual(shelf.name, "cool name") - self.assertEqual(shelf.identifier, "testshelf-%d" % shelf.id) + self.assertEqual(shelf.identifier, f"testshelf-{shelf.id}") def test_edit_shelf_name_not_editable(self, *_): """can't change the name of an non-editable shelf""" diff --git a/bookwyrm/views/shelf.py b/bookwyrm/views/shelf.py index 5d1008d09..6e75cc999 100644 --- a/bookwyrm/views/shelf.py +++ b/bookwyrm/views/shelf.py @@ -146,7 +146,7 @@ def shelve(request): # first we need to remove from the specified shelf change_from_current_identifier = request.POST.get("change-shelf-from") - if not change_from_current_identifier: + if change_from_current_identifier: # find the shelfbook obj and delete it get_object_or_404( models.ShelfBook,