diff --git a/bookwyrm/models/status.py b/bookwyrm/models/status.py
index 0d1d0d839..86e07ad48 100644
--- a/bookwyrm/models/status.py
+++ b/bookwyrm/models/status.py
@@ -12,6 +12,8 @@ from django.db.models import Q
from django.dispatch import receiver
from django.template.loader import get_template
from django.utils import timezone
+from django.utils.translation import gettext_lazy as _
+from django.utils.translation import ngettext_lazy
from model_utils import FieldTracker
from model_utils.managers import InheritanceManager
@@ -178,6 +180,24 @@ class Status(OrderedCollectionPageMixin, BookWyrmModel):
"""you can't boost dms"""
return self.privacy in ["unlisted", "public"]
+ @property
+ def page_title(self):
+ """title of the page when only this status is shown"""
+ return _("%(display_name)s's status") % {"display_name": self.user.display_name}
+
+ @property
+ def page_description(self):
+ """description of the page in meta tags when only this status is shown"""
+ return None
+
+ @property
+ def page_image(self):
+ """image to use as preview in meta tags when only this status is shown"""
+ if self.mention_books.exists():
+ book = self.mention_books.first()
+ return book.preview_image or book.cover
+ return self.user.preview_image
+
def to_replies(self, **kwargs):
"""helper function for loading AP serialized replies to a status"""
return self.to_ordered_collection(
@@ -301,6 +321,10 @@ class BookStatus(Status):
abstract = True
+ @property
+ def page_image(self):
+ return self.book.preview_image or self.book.cover or super().page_image
+
class Comment(BookStatus):
"""like a review but without a rating and transient"""
@@ -332,6 +356,13 @@ class Comment(BookStatus):
activity_serializer = activitypub.Comment
+ @property
+ def page_title(self):
+ return _("%(display_name)s's comment on %(book_title)s") % {
+ "display_name": self.user.display_name,
+ "book_title": self.book.title,
+ }
+
class Quotation(BookStatus):
"""like a review but without a rating and transient"""
@@ -374,6 +405,13 @@ class Quotation(BookStatus):
activity_serializer = activitypub.Quotation
+ @property
+ def page_title(self):
+ return _("%(display_name)s's quote from %(book_title)s") % {
+ "display_name": self.user.display_name,
+ "book_title": self.book.title,
+ }
+
class Review(BookStatus):
"""a book review"""
@@ -403,6 +441,13 @@ class Review(BookStatus):
"""indicate the book in question for mastodon (or w/e) users"""
return self.content
+ @property
+ def page_title(self):
+ return _("%(display_name)s's review of %(book_title)s") % {
+ "display_name": self.user.display_name,
+ "book_title": self.book.title,
+ }
+
activity_serializer = activitypub.Review
pure_type = "Article"
@@ -426,6 +471,18 @@ class ReviewRating(Review):
template = get_template("snippets/generated_status/rating.html")
return template.render({"book": self.book, "rating": self.rating}).strip()
+ @property
+ def page_description(self):
+ return ngettext_lazy(
+ "%(display_name)s rated %(book_title)s: %(display_rating).1f star",
+ "%(display_name)s rated %(book_title)s: %(display_rating).1f stars",
+ "display_rating",
+ ) % {
+ "display_name": self.user.display_name,
+ "book_title": self.book.title,
+ "display_rating": self.rating,
+ }
+
activity_serializer = activitypub.Rating
pure_type = "Note"
diff --git a/bookwyrm/templates/book/book.html b/bookwyrm/templates/book/book.html
index 8e76fb014..4c345832e 100644
--- a/bookwyrm/templates/book/book.html
+++ b/bookwyrm/templates/book/book.html
@@ -9,7 +9,8 @@
{% block title %}{{ book|book_title }}{% endblock %}
{% block opengraph %}
- {% include 'snippets/opengraph.html' with title=book.title description=book|book_description image=book.preview_image %}
+ {% firstof book.preview_image book.cover as book_image %}
+ {% include 'snippets/opengraph.html' with title=book.title description=book|book_description image=book_image %}
{% endblock %}
{% block content %}
diff --git a/bookwyrm/templates/feed/status.html b/bookwyrm/templates/feed/status.html
index c05d2ba46..64e992a01 100644
--- a/bookwyrm/templates/feed/status.html
+++ b/bookwyrm/templates/feed/status.html
@@ -2,13 +2,11 @@
{% load feed_page_tags %}
{% load i18n %}
+{% block title %}{{ title }}{% endblock %}
+
+
{% block opengraph %}
- {% firstof status.book status.mention_books.first as book %}
- {% if book %}
- {% include 'snippets/opengraph.html' with image=preview %}
- {% else %}
- {% include 'snippets/opengraph.html' %}
- {% endif %}
+ {% include 'snippets/opengraph.html' with image=page_image %}
{% endblock %}
diff --git a/bookwyrm/templates/snippets/opengraph.html b/bookwyrm/templates/snippets/opengraph.html
index 1e87a464f..78a6b1b3f 100644
--- a/bookwyrm/templates/snippets/opengraph.html
+++ b/bookwyrm/templates/snippets/opengraph.html
@@ -1,24 +1,25 @@
{% load static %}
-{% if preview_images_enabled is True %}
+{% firstof image site.preview_image as page_image %}
+{% if page_image %}
- {% if image %}
-
-
- {% else %}
-
-
- {% endif %}
+
+
+{% elif site.logo %}
+
+
+
+
{% else %}
-
-
+
+
+
{% endif %}
-
-
-
-
+{% firstof description site.instance_tagline as description %}
+
+
diff --git a/bookwyrm/views/feed.py b/bookwyrm/views/feed.py
index 6e8f820e4..051afb4cc 100644
--- a/bookwyrm/views/feed.py
+++ b/bookwyrm/views/feed.py
@@ -200,19 +200,15 @@ class Status(View):
params=[status.id, visible_thread, visible_thread],
)
- preview = None
- if hasattr(status, "book"):
- preview = status.book.preview_image
- elif status.mention_books.exists():
- preview = status.mention_books.first().preview_image
-
data = {
**feed_page_data(request.user),
**{
"status": status,
"children": children,
"ancestors": ancestors,
- "preview": preview,
+ "title": status.page_title,
+ "description": status.page_description,
+ "page_image": status.page_image,
},
}
return TemplateResponse(request, "feed/status.html", data)