From bd20c9ce2c37ff582241ea030e8f155bfab86b5c Mon Sep 17 00:00:00 2001 From: Hugh Rundle Date: Fri, 22 Oct 2021 18:42:18 +1100 Subject: [PATCH] remove followers group visibility test Also updates description of group.followers_filter() override --- bookwyrm/models/group.py | 2 +- bookwyrm/tests/models/test_group.py | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/bookwyrm/models/group.py b/bookwyrm/models/group.py index 552e2c287..bd5b8d410 100644 --- a/bookwyrm/models/group.py +++ b/bookwyrm/models/group.py @@ -23,7 +23,7 @@ class Group(BookWyrmModel): @classmethod def followers_filter(cls, queryset, viewer): """Override filter for "followers" privacy level to allow non-following - group members to see the existence of groups and group lists""" + group members to see the existence of group-curated lists""" return queryset.exclude( ~Q( # user is not a group member diff --git a/bookwyrm/tests/models/test_group.py b/bookwyrm/tests/models/test_group.py index 275fce196..33341d192 100644 --- a/bookwyrm/tests/models/test_group.py +++ b/bookwyrm/tests/models/test_group.py @@ -75,15 +75,6 @@ class Group(TestCase): ) models.GroupMember.objects.create(group=self.public_group, user=self.capybara) - def test_group_members_can_see_followers_only_groups(self, _): - """follower-only group should not be excluded from group listings for group members viewing""" - - rat_groups = models.Group.privacy_filter(self.rat).all() - badger_groups = models.Group.privacy_filter(self.badger).all() - - self.assertFalse(self.followers_only_group in rat_groups) - self.assertTrue(self.followers_only_group in badger_groups) - def test_group_members_can_see_private_groups(self, _): """direct privacy group should not be excluded from group listings for group members viewing"""