From a7fcd898c218442820566cf916876a1eeda654a3 Mon Sep 17 00:00:00 2001
From: Hugh Rundle <hugh@hughrundle.net>
Date: Sat, 18 Nov 2023 22:10:36 +1100
Subject: [PATCH] middleware for displaying 413 page

When a RequestDataTooBig exception is thrown, users are largely in the dark about what happened and how it can be fixed.
This commit resolves this by inserting middleware to redirect the request to a custom 413 error page.

This exception is thrown when DATA_UPLOAD_MAX_MEMORY_SIZE is exceeded. The default value is 2.5MB.

Fixes #2340
Fixes #2633
---
 bookwyrm/middleware/__init__.py     |  1 +
 bookwyrm/middleware/file_too_big.py | 30 +++++++++++++++++++++++++++++
 bookwyrm/settings.py                |  1 +
 bookwyrm/templates/413.html         | 16 +++++++++++++++
 4 files changed, 48 insertions(+)
 create mode 100644 bookwyrm/middleware/file_too_big.py
 create mode 100644 bookwyrm/templates/413.html

diff --git a/bookwyrm/middleware/__init__.py b/bookwyrm/middleware/__init__.py
index 03843c5a3..85c3a56fe 100644
--- a/bookwyrm/middleware/__init__.py
+++ b/bookwyrm/middleware/__init__.py
@@ -1,3 +1,4 @@
 """ look at all this nice middleware! """
 from .timezone_middleware import TimezoneMiddleware
 from .ip_middleware import IPBlocklistMiddleware
+from .file_too_big import FileTooBig
diff --git a/bookwyrm/middleware/file_too_big.py b/bookwyrm/middleware/file_too_big.py
new file mode 100644
index 000000000..de1349d96
--- /dev/null
+++ b/bookwyrm/middleware/file_too_big.py
@@ -0,0 +1,30 @@
+"""Middleware to display a custom 413 error page"""
+
+from django.http import HttpResponse
+from django.shortcuts import render
+from django.core.exceptions import RequestDataTooBig
+
+
+class FileTooBig:
+    """Middleware to display a custom page when a
+    RequestDataTooBig exception is thrown"""
+
+    def __init__(self, get_response):
+        """boilerplate __init__ from Django docs"""
+
+        self.get_response = get_response
+
+    def __call__(self, request):
+        """If RequestDataTooBig is thrown, render the 413 error page"""
+
+        try:
+            body = request.body  # pylint: disable=unused-variable
+
+        except RequestDataTooBig:
+
+            rendered = render(request, "413.html")
+            response = HttpResponse(rendered)
+            return response
+
+        response = self.get_response(request)
+        return response
diff --git a/bookwyrm/settings.py b/bookwyrm/settings.py
index 4cecc4df6..e3730acf8 100644
--- a/bookwyrm/settings.py
+++ b/bookwyrm/settings.py
@@ -119,6 +119,7 @@ MIDDLEWARE = [
     "bookwyrm.middleware.IPBlocklistMiddleware",
     "django.contrib.messages.middleware.MessageMiddleware",
     "django.middleware.clickjacking.XFrameOptionsMiddleware",
+    "bookwyrm.middleware.FileTooBig",
 ]
 
 ROOT_URLCONF = "bookwyrm.urls"
diff --git a/bookwyrm/templates/413.html b/bookwyrm/templates/413.html
new file mode 100644
index 000000000..337436aae
--- /dev/null
+++ b/bookwyrm/templates/413.html
@@ -0,0 +1,16 @@
+{% extends 'layout.html' %}
+{% load i18n %}
+
+{% block title %}{% trans "File too large" %}{% endblock %}
+
+{% block content %}
+<div class="block">
+    <h1 class="title">{% trans "File too large" %}</h1>
+    <p class="content">{% trans "The file you are uploading is too large." %}</p>
+    <p class="content">
+        {% blocktrans %}
+        You you can try using a smaller file, or ask your BookWyrm server administrator to increase the <code>DATA_UPLOAD_MAX_MEMORY_SIZE</code> setting.
+        {% endblocktrans %}
+    </p>
+</div>
+{% endblock %}