From a46193a37bac9882a52ee5f8e10c801f602b2491 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Sun, 23 Feb 2020 14:26:03 -0800
Subject: [PATCH] Differentiate friends/local/federated reviews

---
 fedireads/models/status.py                |  2 +
 fedireads/static/format.css               |  4 +-
 fedireads/templates/book.html             | 48 +++++++++++++++++------
 fedireads/templates/feed.html             | 12 ++----
 fedireads/templates/snippets/authors.html |  1 +
 fedireads/templates/snippets/book.html    |  6 ++-
 fedireads/templates/snippets/review.html  |  8 ++++
 fedireads/templates/snippets/tabs.html    |  8 ++++
 fedireads/templates/snippets/tag.html     |  2 +-
 fedireads/templatetags/fr_display.py      | 13 ++++++
 fedireads/urls.py                         |  1 +
 fedireads/views.py                        | 43 +++++++++++++++++---
 12 files changed, 118 insertions(+), 30 deletions(-)
 create mode 100644 fedireads/templates/snippets/authors.html
 create mode 100644 fedireads/templates/snippets/review.html
 create mode 100644 fedireads/templates/snippets/tabs.html

diff --git a/fedireads/models/status.py b/fedireads/models/status.py
index 4e3daf045..809c08f3f 100644
--- a/fedireads/models/status.py
+++ b/fedireads/models/status.py
@@ -7,6 +7,8 @@ import re
 
 from fedireads.utils.models import FedireadsModel
 
+# TODO: quote, comment, poll, recommendation, content warning, image
+
 
 class Status(FedireadsModel):
     ''' any post, like a reply to a review, etc '''
diff --git a/fedireads/static/format.css b/fedireads/static/format.css
index a30c5181e..94e01dbd1 100644
--- a/fedireads/static/format.css
+++ b/fedireads/static/format.css
@@ -87,11 +87,11 @@ h2 {
     margin-right: 0;
 }
 
-#feed-tabs {
+.tabs {
     display: flex;
     flex-direction: row;
 }
-.active {
+.tab.active {
     background-color: #FF1654;
 }
 
diff --git a/fedireads/templates/book.html b/fedireads/templates/book.html
index 110a7f841..dbfe7e338 100644
--- a/fedireads/templates/book.html
+++ b/fedireads/templates/book.html
@@ -1,14 +1,15 @@
 {% extends 'layout.html' %}
 {% load fr_display %}
 {% block content %}
-<div id="content">
+<div id="sidebar">
     <div>
-        <div class="book-preview">
-            {% include 'snippets/book.html' with book=book size=large rating=rating description=True shelf_pulldown=True %}
-        </div>
+        <h2><q>{{ book.data.title }}</q> and You</h2>
+        <p>{% if shelf %}On shelf <q>{{ shelf.name }}</q>{% endif %}</p>
+        {% include 'snippets/shelve-button.html' with book=book pulldown=True %}
+
         <div id="tag-cloud">
-            {% for tag in tags %}
-            {% include 'snippets/tag.html' with tag=tag user=request.user %}
+            {% for tag in user_tags %}
+            {% include 'snippets/tag.html' with tag=tag user=request.user user_tags=user_tag_names %}
             {% endfor %}
         </div>
         <form class="tag-form" name="tag" action="/tag/" method="post">
@@ -18,6 +19,33 @@
             <button type="submit">Add tag</button>
         </form>
     </div>
+</div>
+
+<div id="content">
+    <div>
+        <h2><q>{{ book.data.title }}</q> by 
+            {% include 'snippets/authors.html' with book=book %}</h2>
+        <div class="book-preview">
+            {% include 'snippets/book_cover.html' with book=book size=large %}
+            <p>{{ active_tab }} rating: {{ rating | stars }}</p>
+            {% if description %}
+            <blockquote>{{ book.data.description | description }}</blockquote>
+            {% endif %}
+            {% for review in user_reviews %}
+            {% include 'snippets/review.html' with review=review %}
+            {% endfor %}
+            <div>
+                <div id="tag-cloud">
+                    {% for tag in tags %}
+                    {% include 'snippets/tag.html' with tag=tag user=request.user user_tags=user_tag_names %}
+                    {% endfor %}
+                </div>
+            </div>
+
+        </div>
+    </div>
+
+    {% include 'snippets/tabs.html' with tabs=feed_tabs active_tab=active_tab path=path %}
     <div class="reviews">
         <h2>Reviews</h2>
         {% if not reviews %}
@@ -29,13 +57,9 @@
             {{ review_form.as_p }}
             <button type="submit">Post review</button>
         </form>
+        <p>Average rating: {{ rating | stars }}</p>
         {% for review in reviews %}
-        <div class="review">
-            <h4>{{ review.name }}
-                <small>{{ review.rating | stars }} stars, by {% include 'snippets/username.html' with user=review.user %}</small>
-            </h4>
-            <blockquote>{{ review.content }}</blockquote>
-        </div>
+        {% include 'snippets/review.html' with review=review %}
         {% endfor %}
     </div>
 </div>
diff --git a/fedireads/templates/feed.html b/fedireads/templates/feed.html
index f0edc8210..a0d952af4 100644
--- a/fedireads/templates/feed.html
+++ b/fedireads/templates/feed.html
@@ -1,8 +1,8 @@
 {% extends 'layout.html' %}
 {% load fr_display %}
 {% block content %}
-<div id="sidebar">
 
+<div id="sidebar">
     <div>
         {% if shelves %}
         {% for shelf in shelves %}
@@ -33,17 +33,13 @@
     </div>
 </div>
 
+
 <div id="feed">
-    <div id="feed-tabs">
-        {% for tab in feed_tabs %}
-        <div class="{% if tab == active_tab %}active{% endif %}">
-            <a href="/{{ tab }}">{{ tab }}</a>
-        </div>
-        {% endfor %}
-    </div>
+    {% include 'snippets/tabs.html' with tabs=feed_tabs active_tab=active_tab %}
 
     {% for activity in activities %}
         {% include 'snippets/status.html' with activity=activity %}
     {% endfor %}
 </div>
+
 {% endblock %}
diff --git a/fedireads/templates/snippets/authors.html b/fedireads/templates/snippets/authors.html
new file mode 100644
index 000000000..bc392089d
--- /dev/null
+++ b/fedireads/templates/snippets/authors.html
@@ -0,0 +1 @@
+by <a href="/author/{{ book.authors.first.openlibrary_key }}" class="author">{{ book.authors.first.data.name }}</a>
diff --git a/fedireads/templates/snippets/book.html b/fedireads/templates/snippets/book.html
index f2a456eb4..d25b36c82 100644
--- a/fedireads/templates/snippets/book.html
+++ b/fedireads/templates/snippets/book.html
@@ -3,7 +3,9 @@
 <p class="title">
     <a href="/book/{{ book.openlibrary_key }}">{{ book.data.title }}</a>
 </p>
-<p>by <a href="/author/{{ book.authors.first.openlibrary_key }}" class="author">{{ book.authors.first.data.name }}</a></p>
+<p>
+    {% include 'snippets/authors.html' with book=book %}
+</p>
 
 {% if rating %}
 {{ rating | stars }} {{ rating }}
@@ -13,4 +15,4 @@
 <blockquote>{{ book.data.description | description }}</blockquote>
 {% endif %}
 
-{% include 'snippets/shelve-button.html' with book=book pulldown=shelf_pulldown%}
+{% include 'snippets/shelve-button.html' with book=book pulldown=shelf_pulldown %}
diff --git a/fedireads/templates/snippets/review.html b/fedireads/templates/snippets/review.html
new file mode 100644
index 000000000..76c2f4a4e
--- /dev/null
+++ b/fedireads/templates/snippets/review.html
@@ -0,0 +1,8 @@
+{% load fr_display %}
+<div class="review">
+    <h4>{{ review.name }}
+        <small>{{ review.rating | stars }} stars, by {% include 'snippets/username.html' with user=review.user %}</small>
+    </h4>
+    <blockquote>{{ review.content }}</blockquote>
+</div>
+
diff --git a/fedireads/templates/snippets/tabs.html b/fedireads/templates/snippets/tabs.html
new file mode 100644
index 000000000..7708d3df3
--- /dev/null
+++ b/fedireads/templates/snippets/tabs.html
@@ -0,0 +1,8 @@
+<div class="tabs">
+    {% for tab in tabs %}
+    <div class="tab {% if tab == active_tab %}active{% endif %}">
+        <a href="{{ path }}/{{ tab }}">{{ tab }}</a>
+    </div>
+    {% endfor %}
+</div>
+
diff --git a/fedireads/templates/snippets/tag.html b/fedireads/templates/snippets/tag.html
index e298039ca..ab32419d5 100644
--- a/fedireads/templates/snippets/tag.html
+++ b/fedireads/templates/snippets/tag.html
@@ -1,6 +1,6 @@
 <div class="tag">
     <a href="/tag/{{ tag.identifier }}">{{ tag.name }}</a>
-    {% if tag.name in user_tags %}
+    {% if tag.identifier in user_tags %}
     <form class="tag-form" name="tag" action="/untag/" method="post">
         {% csrf_token %}
         <input type="hidden" name="book" value="{{ book.openlibrary_key }}"></input>
diff --git a/fedireads/templatetags/fr_display.py b/fedireads/templatetags/fr_display.py
index d8d3a0a30..41d5591d9 100644
--- a/fedireads/templatetags/fr_display.py
+++ b/fedireads/templatetags/fr_display.py
@@ -80,3 +80,16 @@ def shelve_button_text(context, book):
         return 'I\'m done!'
     return 'Want to read'
 
+
+@register.simple_tag(takes_context=True)
+def current_shelf(context, book):
+    ''' check what shelf a user has a book on, if any '''
+    try:
+        shelf = models.ShelfBook.objects.get(
+            shelf__user=context['user'],
+            book=book
+        )
+    except models.ShelfBook.DoesNotExist:
+        return None
+    return shelf.name
+
diff --git a/fedireads/urls.py b/fedireads/urls.py
index 2fd33e262..650adc45a 100644
--- a/fedireads/urls.py
+++ b/fedireads/urls.py
@@ -43,6 +43,7 @@ urlpatterns = [
     re_path(r'%s/edit/?$' % user_path, views.edit_profile_page),
     re_path(r'^user/edit/?$', views.edit_profile_page),
     re_path(r'^book/(?P<book_identifier>\w+)/?$', views.book_page),
+    re_path(r'^book/(?P<book_identifier>\w+)/(?P<tab>friends|local|federated)?$', views.book_page),
     re_path(r'^author/(?P<author_identifier>\w+)/?$', views.author_page),
     re_path(r'^tag/(?P<tag_id>[\w-]+)/?$', views.tag_page),
     re_path(r'^shelf/%s/(?P<shelf_identifier>[\w-]+)/?$' % username_regex, views.shelf_page),
diff --git a/fedireads/views.py b/fedireads/views.py
index c2d675c24..3dab26d76 100644
--- a/fedireads/views.py
+++ b/fedireads/views.py
@@ -185,12 +185,38 @@ def edit_profile_page(request, username):
     return TemplateResponse(request, 'edit_user.html', data)
 
 
-
-def book_page(request, book_identifier):
+@login_required
+def book_page(request, book_identifier, tab='friends'):
     ''' info about a book '''
     book = openlibrary.get_or_create_book(book_identifier)
-    # TODO: again, post privacy?
-    reviews = models.Review.objects.filter(book=book)
+
+    user_reviews = models.Review.objects.filter(user=request.user, book=book).all()
+
+    if tab == 'friends':
+        reviews = models.Review.objects.filter(
+            Q(user__followers=request.user, privacy='public') | \
+                Q(mention_users=request.user),
+            book=book,
+        )
+    elif tab == 'local':
+        reviews = models.Review.objects.filter(
+            Q(privacy='public') | \
+                Q(mention_users=request.user),
+            user__local=True,
+            book=book,
+        )
+    else:
+        reviews = models.Review.objects.filter(
+            Q(privacy='public') | \
+                Q(mention_users=request.user),
+            book=book,
+        )
+
+    try:
+        shelf = models.Shelf.objects.get(user=request.user, book=book)
+    except models.Shelf.DoesNotExist:
+        shelf = None
+
     rating = reviews.aggregate(Avg('rating'))
     tags = models.Tag.objects.filter(
         book=book
@@ -199,18 +225,25 @@ def book_page(request, book_identifier):
     ).distinct().all()
     user_tags = models.Tag.objects.filter(
         book=book, user=request.user
-    ).values_list('name', flat=True)
+    ).all()
 
     review_form = forms.ReviewForm()
     tag_form = forms.TagForm()
     data = {
         'book': book,
+        'shelf': shelf,
+        'user_reviews': user_reviews,
+        'user_rating': user_reviews.aggregate(Avg('rating')),
         'reviews': reviews,
         'rating': rating['rating__avg'],
         'tags': tags,
         'user_tags': user_tags,
+        'user_tag_names': user_tags.values_list('identifier', flat=True),
         'review_form': review_form,
         'tag_form': tag_form,
+        'feed_tabs': ['friends', 'local', 'federated'],
+        'active_tab': tab,
+        'path': '/book/%s' % book_identifier,
     }
     return TemplateResponse(request, 'book.html', data)