diff --git a/bookwyrm/static/js/status_cache.js b/bookwyrm/static/js/status_cache.js index 49f1c1295..03301a215 100644 --- a/bookwyrm/static/js/status_cache.js +++ b/bookwyrm/static/js/status_cache.js @@ -93,8 +93,10 @@ let StatusCache = new class { if (response.headers.get("forceReload")) { BookWyrm.addRemoveClass(form, 'is-processing', true); trigger.setAttribute('disabled', null); + return location.reload(); } + if (!response.ok) { throw new Error(); } diff --git a/bookwyrm/views/reading.py b/bookwyrm/views/reading.py index 334235b34..75a45f245 100644 --- a/bookwyrm/views/reading.py +++ b/bookwyrm/views/reading.py @@ -17,6 +17,7 @@ from .helpers import load_date_in_user_tz_as_utc @method_decorator(login_required, name="dispatch") # pylint: disable=no-self-use +# pylint: disable=too-many-return-statements class ReadingStatus(View): """consider reading a book""" diff --git a/bookwyrm/views/shelf/shelf_actions.py b/bookwyrm/views/shelf/shelf_actions.py index f431c1fab..77053f534 100644 --- a/bookwyrm/views/shelf/shelf_actions.py +++ b/bookwyrm/views/shelf/shelf_actions.py @@ -94,8 +94,8 @@ def shelve(request): @require_POST def unshelve(request, referer=None, book_id=False): """remove a book from a user's shelf""" - id = book_id if book_id else request.POST.get("book") - book = get_object_or_404(models.Edition, id=id) + identity = book_id if book_id else request.POST.get("book") + book = get_object_or_404(models.Edition, id=identity) shelf_book = get_object_or_404( models.ShelfBook, book=book, shelf__id=request.POST["shelf"] ) diff --git a/bookwyrm/views/status.py b/bookwyrm/views/status.py index 588dcf6ac..144408b50 100644 --- a/bookwyrm/views/status.py +++ b/bookwyrm/views/status.py @@ -54,6 +54,7 @@ class CreateStatus(View): data = {"book": book} return TemplateResponse(request, "compose.html", data) + # pylint: disable=too-many-branches def post(self, request, status_type, existing_status_id=None): """create status of whatever type""" created = not existing_status_id