From 8532c9a46b8d4265fbd923b39d2a50471b584a80 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Sat, 16 Jan 2021 13:29:28 -0800
Subject: [PATCH] tests goal views

---
 bookwyrm/tests/views/test_goal.py | 114 ++++++++++++++++++++++++++++++
 bookwyrm/views/goal.py            |   4 +-
 2 files changed, 116 insertions(+), 2 deletions(-)
 create mode 100644 bookwyrm/tests/views/test_goal.py

diff --git a/bookwyrm/tests/views/test_goal.py b/bookwyrm/tests/views/test_goal.py
new file mode 100644
index 000000000..343399d0a
--- /dev/null
+++ b/bookwyrm/tests/views/test_goal.py
@@ -0,0 +1,114 @@
+''' test for app action functionality '''
+from unittest.mock import patch
+
+from django.contrib.auth.models import AnonymousUser
+from django.template.response import TemplateResponse
+from django.test import TestCase
+from django.test.client import RequestFactory
+
+from bookwyrm import models, views
+
+
+class GoalViews(TestCase):
+    ''' viewing and creating statuses '''
+    def setUp(self):
+        ''' we need basic test data and mocks '''
+        self.factory = RequestFactory()
+        self.local_user = models.User.objects.create_user(
+            'mouse@local.com', 'mouse@mouse.com', 'mouseword',
+            local=True, localname='mouse',
+            remote_id='https://example.com/users/mouse',
+        )
+        self.rat = models.User.objects.create_user(
+            'rat@local.com', 'rat@rat.com', 'ratword',
+            local=True, localname='rat',
+            remote_id='https://example.com/users/rat',
+        )
+        self.book = models.Edition.objects.create(
+            title='Example Edition',
+            remote_id='https://example.com/book/1',
+        )
+        self.anonymous_user = AnonymousUser
+        self.anonymous_user.is_authenticated = False
+
+
+    def test_goal_page_no_goal(self):
+        ''' view a reading goal page for another's unset goal '''
+        view = views.Goal.as_view()
+        request = self.factory.get('')
+        request.user = self.rat
+
+        result = view(request, self.local_user.localname, 2020)
+        self.assertEqual(result.status_code, 404)
+
+    def test_goal_page_no_goal_self(self):
+        ''' view a reading goal page for your own unset goal '''
+        view = views.Goal.as_view()
+        request = self.factory.get('')
+        request.user = self.local_user
+
+        result = view(request, self.local_user.localname, 2020)
+        self.assertIsInstance(result, TemplateResponse)
+
+
+    def test_goal_page_anonymous(self):
+        ''' can't view it without login '''
+        view = views.Goal.as_view()
+        request = self.factory.get('')
+        request.user = self.anonymous_user
+
+        result = view(request, self.local_user.localname, 2020)
+        self.assertEqual(result.status_code, 302)
+
+    def test_goal_page_public(self):
+        ''' view a user's public goal '''
+        models.AnnualGoal.objects.create(
+            user=self.local_user,
+            year=2020,
+            goal=128937123,
+            privacy='public')
+        view = views.Goal.as_view()
+        request = self.factory.get('')
+        request.user = self.rat
+
+        result = view(request, self.local_user.localname, 2020)
+        self.assertIsInstance(result, TemplateResponse)
+
+    def test_goal_page_private(self):
+        ''' view a user's private goal '''
+        models.AnnualGoal.objects.create(
+            user=self.local_user,
+            year=2020,
+            goal=15,
+            privacy='followers')
+        view = views.Goal.as_view()
+        request = self.factory.get('')
+        request.user = self.rat
+
+        result = view(request, self.local_user.localname, 2020)
+        self.assertEqual(result.status_code, 404)
+
+
+    def test_create_goal(self):
+        ''' create a new goal '''
+        view = views.Goal.as_view()
+        request = self.factory.post('', {
+            'user': self.local_user.id,
+            'goal': 10,
+            'year': 2020,
+            'privacy': 'unlisted',
+            'post-status': True
+        })
+        request.user = self.local_user
+        with patch('bookwyrm.broadcast.broadcast_task.delay'):
+            view(request, self.local_user.localname, 2020)
+
+        goal = models.AnnualGoal.objects.get()
+        self.assertEqual(goal.user, self.local_user)
+        self.assertEqual(goal.goal, 10)
+        self.assertEqual(goal.year, 2020)
+        self.assertEqual(goal.privacy, 'unlisted')
+
+        status = models.GeneratedNote.objects.get()
+        self.assertEqual(status.user, self.local_user)
+        self.assertEqual(status.privacy, 'unlisted')
diff --git a/bookwyrm/views/goal.py b/bookwyrm/views/goal.py
index 4404d008d..45fe614b7 100644
--- a/bookwyrm/views/goal.py
+++ b/bookwyrm/views/goal.py
@@ -24,7 +24,7 @@ class Goal(View):
             year=year, user=user
         ).first()
         if not goal and user != request.user:
-            return redirect('/')
+            return HttpResponseNotFound()
 
         if goal and not object_visible_to_user(request.user, goal):
             return HttpResponseNotFound()
@@ -58,7 +58,7 @@ class Goal(View):
                 'year': year,
             }
             return TemplateResponse(request, 'goal.html', data)
-        form.save()
+        goal = form.save()
 
         if request.POST.get('post-status'):
             # create status, if appropraite