From db6246e35977ba75a7ef8090b85a84bf474b8a00 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Sat, 1 May 2021 22:20:23 -0700 Subject: [PATCH 1/2] Fixes error on empty search results --- bookwyrm/views/search.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bookwyrm/views/search.py b/bookwyrm/views/search.py index 4b9100fb7..558c20391 100644 --- a/bookwyrm/views/search.py +++ b/bookwyrm/views/search.py @@ -56,10 +56,11 @@ class Search(View): results = endpoints[search_type]( query, request.user, min_confidence, search_remote ) - paginated = Paginator(results, PAGE_LENGTH).get_page( - request.GET.get("page") - ) - data["results"] = paginated + if results: + paginated = Paginator(results, PAGE_LENGTH).get_page( + request.GET.get("page") + ) + data["results"] = paginated return TemplateResponse(request, "search/{:s}.html".format(search_type), data) From df1c324d2dcbdd845d4e8af46d9c19abe405057b Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Mon, 3 May 2021 10:46:02 -0700 Subject: [PATCH 2/2] Updates test --- bookwyrm/tests/views/test_search.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bookwyrm/tests/views/test_search.py b/bookwyrm/tests/views/test_search.py index b2f3bbcc3..a6d7c36e8 100644 --- a/bookwyrm/tests/views/test_search.py +++ b/bookwyrm/tests/views/test_search.py @@ -127,7 +127,7 @@ class Views(TestCase): response = view(request) response.render() - self.assertEqual(response.context_data["results"].object_list.count(), 0) + self.assertFalse("results" in response.context_data) def test_search_lists(self): """searches remote connectors"""