diff --git a/fedireads/migrations/0001_initial.py b/fedireads/migrations/0001_initial.py index 197025785..feeb008fa 100644 --- a/fedireads/migrations/0001_initial.py +++ b/fedireads/migrations/0001_initial.py @@ -1,4 +1,4 @@ -# Generated by Django 3.0.2 on 2020-01-29 02:56 +# Generated by Django 3.0.2 on 2020-01-29 06:31 from django.conf import settings import django.contrib.auth.models @@ -42,6 +42,7 @@ class Migration(migrations.Migration): ('summary', models.TextField(blank=True, null=True)), ('local', models.BooleanField(default=True)), ('localname', models.CharField(blank=True, max_length=255, null=True, unique=True)), + ('name', models.CharField(blank=True, max_length=100, null=True)), ('avatar', models.ImageField(blank=True, null=True, upload_to='uploads/')), ('created_date', models.DateTimeField(auto_now_add=True)), ('updated_date', models.DateTimeField(auto_now=True)), @@ -174,7 +175,7 @@ class Migration(migrations.Migration): name='Review', fields=[ ('activity_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='fedireads.Activity')), - ('name', models.TextField()), + ('name', models.CharField(max_length=255)), ('rating', models.IntegerField(default=0)), ('review_content', models.TextField()), ('book', models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, to='fedireads.Book')), diff --git a/fedireads/models.py b/fedireads/models.py index b59b2dfe5..eb9f4aecf 100644 --- a/fedireads/models.py +++ b/fedireads/models.py @@ -28,6 +28,8 @@ class User(AbstractUser): blank=True, unique=True ) + # name is your display name, which you can change at will + name = models.CharField(max_length=100, blank=True, null=True) avatar = models.ImageField(upload_to='uploads/', blank=True, null=True) # TODO: a field for if non-local users are readers or others followers = models.ManyToManyField('self', symmetrical=False) @@ -131,7 +133,7 @@ class Review(Activity): ''' a book review ''' book = models.ForeignKey('Book', on_delete=models.PROTECT) work = models.ForeignKey('Work', on_delete=models.PROTECT) - name = models.TextField() + name = models.CharField(max_length=255) # TODO: validation rating = models.IntegerField(default=0) review_content = models.TextField() diff --git a/fedireads/settings.py b/fedireads/settings.py index 698016bb2..d0d225704 100644 --- a/fedireads/settings.py +++ b/fedireads/settings.py @@ -119,4 +119,5 @@ USE_TZ = True STATIC_URL = '/static/' MEDIA_URL = '/images/' -MEDIA_ROOT = os.path.join(BASE_DIR, MEDIA_URL) +# TODO: this super doesn't work when I do a join on BASE_DIR +MEDIA_ROOT = '/Users/mouse/Personal/fedireads/images/' diff --git a/fedireads/static/format.css b/fedireads/static/format.css index bd10ab34b..c53691c0a 100644 --- a/fedireads/static/format.css +++ b/fedireads/static/format.css @@ -35,6 +35,7 @@ h2 { } #actions { flex-grow: 0; + text-align: right; } #top-bar { @@ -88,10 +89,6 @@ h2 { width: 90%; } -form label { - display: block; -} - .review-form textarea { width: 30rem; height: 10rem; diff --git a/fedireads/templates/book.html b/fedireads/templates/book.html index 073bfadbe..e6837d345 100644 --- a/fedireads/templates/book.html +++ b/fedireads/templates/book.html @@ -13,15 +13,7 @@
- - - + {{ review_form.as_p }}
diff --git a/fedireads/templates/edit_user.html b/fedireads/templates/edit_user.html index dc66d6558..e59a3ea26 100644 --- a/fedireads/templates/edit_user.html +++ b/fedireads/templates/edit_user.html @@ -2,51 +2,13 @@ {% block content %}
+

{% if user.localname %}{{ user.localname }}{% else %}{{ user.username }}{% endif %}

-
- + + {% csrf_token %} + {{ form.as_p }}
-

{% if user.localname %}{{ user.localname }}{% else %}{{ user.username }}{% endif %}

- {% if is_self %}Edit profile -

Since {{ user.created_date }}

- {% endif %} - {% if not is_self %} - {% if not following %} -
- - -
- {% else %} -
- - -
- {% endif %} - {% endif %}
- -
-

Books

- {% for book in books.all %} -
- {{ book.data.title }} by {{ book.authors.first.data.name }} -
- {% endfor %} -
- -
-

Followers

- {% for follower in user.followers.all %} -
- {{ follower.username }} -
- - -
-
- {% endfor %} -
-
{% endblock %} diff --git a/fedireads/templates/feed.html b/fedireads/templates/feed.html index 657b6e410..23057c178 100644 --- a/fedireads/templates/feed.html +++ b/fedireads/templates/feed.html @@ -47,7 +47,7 @@ {% for activity in activities %}

- + {# TODO: a helper function for displaying a username #} {% if activity.user.localname %}{{ activity.user.localname }}{% else %}{{ activity.user.username }}{% endif %} diff --git a/fedireads/templates/layout.html b/fedireads/templates/layout.html index 243b51550..3923d73ec 100644 --- a/fedireads/templates/layout.html +++ b/fedireads/templates/layout.html @@ -27,20 +27,21 @@
{% if user.is_authenticated %}
- Welcome, {% if request.user.localname %}{{ request.user.localname }}{% else %}{{ request.user.username }}{% endif %} + Welcome, {% if request.user.localname %}{{ request.user.localname }}{% else %}{{ request.user.username }}{% endif %}
{% else %}
- - + {% for field in login_form %} + {{ field }} + {% endfor %}
{% endif %}
diff --git a/fedireads/templates/login.html b/fedireads/templates/login.html index bfb54605f..a5b879112 100644 --- a/fedireads/templates/login.html +++ b/fedireads/templates/login.html @@ -3,13 +3,7 @@
- - - + {{ login_form.as_p }}
Create a new account diff --git a/fedireads/templates/register.html b/fedireads/templates/register.html index f4fb80478..761ce4c70 100644 --- a/fedireads/templates/register.html +++ b/fedireads/templates/register.html @@ -3,17 +3,7 @@
- - - - - + {{ register_form.as_p }}
diff --git a/fedireads/templates/user.html b/fedireads/templates/user.html index 0cab7b404..b8aa8a192 100644 --- a/fedireads/templates/user.html +++ b/fedireads/templates/user.html @@ -2,8 +2,11 @@ {% block content %}