From 78775241166616e4004c92d17d0ec8bd38399a4b Mon Sep 17 00:00:00 2001 From: Joachim Date: Sat, 12 Feb 2022 16:25:40 +0100 Subject: [PATCH] ARIA button, link, and menuitem must have an accessible name https://dequeuniversity.com/rules/axe/4.3/aria-command-name In this case, the menuitem wasn't displayed (because the div was hidden). I prefer not to include the menuitem in that situation. --- .../snippets/shelve_button/shelve_button_dropdown_options.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bookwyrm/templates/snippets/shelve_button/shelve_button_dropdown_options.html b/bookwyrm/templates/snippets/shelve_button/shelve_button_dropdown_options.html index 1fa26a886..f97dc2f35 100644 --- a/bookwyrm/templates/snippets/shelve_button/shelve_button_dropdown_options.html +++ b/bookwyrm/templates/snippets/shelve_button/shelve_button_dropdown_options.html @@ -5,10 +5,10 @@ {% with next_shelf_identifier=active_shelf.shelf.identifier|next_shelf %} {% for shelf in shelves %} +{% if next_shelf_identifier != shelf.identifier %} {% comparison_bool shelf.identifier active_shelf.shelf.identifier as is_current %} +{% endif %} {% endfor %} {% if readthrough and active_shelf.shelf.identifier != 'read' %}