From 55a3a28d49f187d3de0391ea3beaba0e75620dac Mon Sep 17 00:00:00 2001
From: Joachim <joachim.robert@protonmail.com>
Date: Sun, 23 May 2021 21:17:14 +0200
Subject: [PATCH 1/5] Add microformats to author page

---
 bookwyrm/templates/author/author.html | 33 ++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/bookwyrm/templates/author/author.html b/bookwyrm/templates/author/author.html
index aa99cbe27..496012a82 100644
--- a/bookwyrm/templates/author/author.html
+++ b/bookwyrm/templates/author/author.html
@@ -22,42 +22,59 @@
     </div>
 </div>
 
-<div class="block content columns">
-    {% if author.aliases or author.born or author.died or author.wikipedia_link %}
+<div class="block content columns" itemscope itemtype="https://schema.org/Person">
+    <meta itemprop="name" content="{{ author.name }}">
+
+    {% if author.aliases or author.born or author.died or author.wikipedia_link or author.openlibrary_key or author.inventaire_id %}
     <div class="column is-narrow">
         <div class="box">
             <dl>
                 {% if author.aliases %}
                 <div class="is-flex">
                     <dt class="mr-1">{% trans "Aliases:" %}</dt>
-                    <dd itemprop="aliases">{{ author.aliases|join:', ' }}</dd>
+                    <dd>
+                        {% for alias in author.aliases %}
+                        <span itemprop="alternateName">{{alias}}</span>{% if not forloop.last %},{% endif %}
+                        {% endfor %}
+                    </dd>
                 </div>
                 {% endif %}
                 {% if author.born %}
                 <div class="is-flex">
                     <dt class="mr-1">{% trans "Born:" %}</dt>
-                    <dd itemprop="aliases">{{ author.born|naturalday }}</dd>
+                    <dd itemprop="birthDate">{{ author.born|naturalday }}</dd>
                 </div>
                 {% endif %}
                 {% if author.died %}
                 <div class="is-flex">
                     <dt class="mr-1">{% trans "Died:" %}</dt>
-                    <dd itemprop="aliases">{{ author.died|naturalday }}</dd>
+                    <dd itemprop="deathDate">{{ author.died|naturalday }}</dd>
                 </div>
                 {% endif %}
             </dl>
 
             {% if author.wikipedia_link %}
-            <p><a href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">{% trans "Wikipedia" %}</a></p>
+            <p>
+                <link itemprop="sameAs" href="{{ author.wikipedia_link }}" />
+                <a href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
+                    {% trans "Wikipedia" %}
+                </a>
+            </p>
             {% endif %}
             {% if author.openlibrary_key %}
             <p class="mb-0">
-                <a href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">{% trans "View on OpenLibrary" %}</a>
+                <link itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" />
+                <a href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
+                    {% trans "View on OpenLibrary" %}
+                </a>
             </p>
             {% endif %}
             {% if author.inventaire_id %}
             <p class="mb-0">
-                <a href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">{% trans "View on Inventaire" %}</a>
+                <link itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" />
+                <a href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
+                    {% trans "View on Inventaire" %}
+                </a>
             </p>
             {% endif %}
         </div>

From 58c07d16779d3d1f7a5f8c43518c41efad6e891b Mon Sep 17 00:00:00 2001
From: Joachim <joachim.robert@protonmail.com>
Date: Mon, 24 May 2021 12:36:48 +0200
Subject: [PATCH 2/5] Apply review suggestions

---
 bookwyrm/templates/author/author.html | 29 +++++++++++++--------------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/bookwyrm/templates/author/author.html b/bookwyrm/templates/author/author.html
index 496012a82..de7d230f9 100644
--- a/bookwyrm/templates/author/author.html
+++ b/bookwyrm/templates/author/author.html
@@ -22,7 +22,7 @@
     </div>
 </div>
 
-<div class="block content columns" itemscope itemtype="https://schema.org/Person">
+<div class="block columns" itemscope itemtype="https://schema.org/Person">
     <meta itemprop="name" content="{{ author.name }}">
 
     {% if author.aliases or author.born or author.died or author.wikipedia_link or author.openlibrary_key or author.inventaire_id %}
@@ -32,11 +32,11 @@
                 {% if author.aliases %}
                 <div class="is-flex">
                     <dt class="mr-1">{% trans "Aliases:" %}</dt>
-                    <dd>
-                        {% for alias in author.aliases %}
-                        <span itemprop="alternateName">{{alias}}</span>{% if not forloop.last %},{% endif %}
-                        {% endfor %}
-                    </dd>
+                    {% for alias in author.aliases %}
+                        <dd itemprop="alternateName" content="{{alias}}">
+                            {{alias}}{% if not forloop.last %},{% endif %}
+                        </dd>
+                    {% endfor %}
                 </div>
                 {% endif %}
                 {% if author.born %}
@@ -54,25 +54,24 @@
             </dl>
 
             {% if author.wikipedia_link %}
-            <p>
-                <link itemprop="sameAs" href="{{ author.wikipedia_link }}" />
-                <a href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
+            <p class="mt-1">
+                <a itemprop="sameAs" href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
                     {% trans "Wikipedia" %}
                 </a>
             </p>
             {% endif %}
+            
             {% if author.openlibrary_key %}
-            <p class="mb-0">
-                <link itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" />
-                <a href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
+            <p class="mt-1">
+                <a itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
                     {% trans "View on OpenLibrary" %}
                 </a>
             </p>
             {% endif %}
+            
             {% if author.inventaire_id %}
-            <p class="mb-0">
-                <link itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" />
-                <a href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
+            <p class="mt-1">
+                <a itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
                     {% trans "View on Inventaire" %}
                 </a>
             </p>

From 594f7b370875e6f469c2c84fc075c0ee8ff87347 Mon Sep 17 00:00:00 2001
From: Joachim <joachim.robert@protonmail.com>
Date: Mon, 24 May 2021 12:51:18 +0200
Subject: [PATCH 3/5] Style fixes

---
 bookwyrm/templates/author/author.html | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/bookwyrm/templates/author/author.html b/bookwyrm/templates/author/author.html
index de7d230f9..1d317492f 100644
--- a/bookwyrm/templates/author/author.html
+++ b/bookwyrm/templates/author/author.html
@@ -26,43 +26,43 @@
     <meta itemprop="name" content="{{ author.name }}">
 
     {% if author.aliases or author.born or author.died or author.wikipedia_link or author.openlibrary_key or author.inventaire_id %}
-    <div class="column is-narrow">
+    <div class="column is-two-fifths">
         <div class="box">
             <dl>
                 {% if author.aliases %}
-                <div class="is-flex">
-                    <dt class="mr-1">{% trans "Aliases:" %}</dt>
+                <div class="is-flex is-flex-wrap-wrap mb-2">
+                    <dt class="has-text-weight-bold mr-1">{% trans "Aliases:" %}</dt>
                     {% for alias in author.aliases %}
                         <dd itemprop="alternateName" content="{{alias}}">
-                            {{alias}}{% if not forloop.last %},{% endif %}
+                            {{alias}}{% if not forloop.last %},&nbsp;{% endif %}
                         </dd>
                     {% endfor %}
                 </div>
                 {% endif %}
                 {% if author.born %}
-                <div class="is-flex">
-                    <dt class="mr-1">{% trans "Born:" %}</dt>
+                <div class="is-flex mb-2">
+                    <dt class="has-text-weight-bold mr-1">{% trans "Born:" %}</dt>
                     <dd itemprop="birthDate">{{ author.born|naturalday }}</dd>
                 </div>
                 {% endif %}
                 {% if author.died %}
-                <div class="is-flex">
-                    <dt class="mr-1">{% trans "Died:" %}</dt>
+                <div class="is-flex mb-2">
+                    <dt class="has-text-weight-bold mr-1">{% trans "Died:" %}</dt>
                     <dd itemprop="deathDate">{{ author.died|naturalday }}</dd>
                 </div>
                 {% endif %}
             </dl>
 
             {% if author.wikipedia_link %}
-            <p class="mt-1">
+            <p class="mb-1">
                 <a itemprop="sameAs" href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
                     {% trans "Wikipedia" %}
                 </a>
             </p>
             {% endif %}
-            
+
             {% if author.openlibrary_key %}
-            <p class="mt-1">
+            <p class="mb-1">
                 <a itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
                     {% trans "View on OpenLibrary" %}
                 </a>
@@ -70,7 +70,7 @@
             {% endif %}
             
             {% if author.inventaire_id %}
-            <p class="mt-1">
+            <p class="mb-1">
                 <a itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
                     {% trans "View on Inventaire" %}
                 </a>

From 25858ed3aa5da7e9f41281d9590faff31fe8e29a Mon Sep 17 00:00:00 2001
From: Joachim <joachim.robert@protonmail.com>
Date: Mon, 24 May 2021 12:51:41 +0200
Subject: [PATCH 4/5] Added LibraryThing and Goodreads links

---
 bookwyrm/templates/author/author.html | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/bookwyrm/templates/author/author.html b/bookwyrm/templates/author/author.html
index 1d317492f..9b3c637e3 100644
--- a/bookwyrm/templates/author/author.html
+++ b/bookwyrm/templates/author/author.html
@@ -76,6 +76,22 @@
                 </a>
             </p>
             {% endif %}
+
+            {% if author.librarything_key %}
+            <p class="mb-1">
+                <a itemprop="sameAs" href="https://www.librarything.com/author/{{ author.librarything_key }}" target="_blank" rel="noopener">
+                    {% trans "View on LibraryThing" %}
+                </a>
+            </p>
+            {% endif %}
+            
+            {% if author.goodreads_key %}
+            <p class="mb-1">
+                <a itemprop="sameAs" href="https://www.goodreads.com/author/show/{{ author.goodreads_key }}" target="_blank" rel="noopener">
+                    {% trans "View on Goodreads" %}
+                </a>
+            </p>
+            {% endif %}
         </div>
     </div>
     {% endif %}

From b72580daf61ff0dd22dd05ad8ecbabe92301b3b4 Mon Sep 17 00:00:00 2001
From: Joachim <joachim.robert@protonmail.com>
Date: Mon, 24 May 2021 17:17:12 +0200
Subject: [PATCH 5/5] Update author.html

---
 bookwyrm/templates/author/author.html | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/bookwyrm/templates/author/author.html b/bookwyrm/templates/author/author.html
index 9b3c637e3..f4f308f2d 100644
--- a/bookwyrm/templates/author/author.html
+++ b/bookwyrm/templates/author/author.html
@@ -27,10 +27,10 @@
 
     {% if author.aliases or author.born or author.died or author.wikipedia_link or author.openlibrary_key or author.inventaire_id %}
     <div class="column is-two-fifths">
-        <div class="box">
+        <div class="box py-2">
             <dl>
                 {% if author.aliases %}
-                <div class="is-flex is-flex-wrap-wrap mb-2">
+                <div class="is-flex is-flex-wrap-wrap my-1">
                     <dt class="has-text-weight-bold mr-1">{% trans "Aliases:" %}</dt>
                     {% for alias in author.aliases %}
                         <dd itemprop="alternateName" content="{{alias}}">
@@ -39,14 +39,16 @@
                     {% endfor %}
                 </div>
                 {% endif %}
+
                 {% if author.born %}
-                <div class="is-flex mb-2">
+                <div class="is-flex my-1">
                     <dt class="has-text-weight-bold mr-1">{% trans "Born:" %}</dt>
                     <dd itemprop="birthDate">{{ author.born|naturalday }}</dd>
                 </div>
                 {% endif %}
+
                 {% if author.died %}
-                <div class="is-flex mb-2">
+                <div class="is-flex my-1">
                     <dt class="has-text-weight-bold mr-1">{% trans "Died:" %}</dt>
                     <dd itemprop="deathDate">{{ author.died|naturalday }}</dd>
                 </div>
@@ -54,7 +56,7 @@
             </dl>
 
             {% if author.wikipedia_link %}
-            <p class="mb-1">
+            <p class="my-1">
                 <a itemprop="sameAs" href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
                     {% trans "Wikipedia" %}
                 </a>
@@ -62,7 +64,7 @@
             {% endif %}
 
             {% if author.openlibrary_key %}
-            <p class="mb-1">
+            <p class="my-1">
                 <a itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
                     {% trans "View on OpenLibrary" %}
                 </a>
@@ -70,7 +72,7 @@
             {% endif %}
             
             {% if author.inventaire_id %}
-            <p class="mb-1">
+            <p class="my-1">
                 <a itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
                     {% trans "View on Inventaire" %}
                 </a>
@@ -78,7 +80,7 @@
             {% endif %}
 
             {% if author.librarything_key %}
-            <p class="mb-1">
+            <p class="my-1">
                 <a itemprop="sameAs" href="https://www.librarything.com/author/{{ author.librarything_key }}" target="_blank" rel="noopener">
                     {% trans "View on LibraryThing" %}
                 </a>
@@ -86,7 +88,7 @@
             {% endif %}
             
             {% if author.goodreads_key %}
-            <p class="mb-1">
+            <p class="my-1">
                 <a itemprop="sameAs" href="https://www.goodreads.com/author/show/{{ author.goodreads_key }}" target="_blank" rel="noopener">
                     {% trans "View on Goodreads" %}
                 </a>