From 28f07f772994363a8fbb68fcbb2f2596f9f3ddd5 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Mon, 29 Mar 2021 18:47:21 -0700
Subject: [PATCH] Fixes error pages

---
 bookwyrm/templates/{notfound.html => 404.html} |  0
 bookwyrm/templates/{error.html => 500.html}    |  0
 bookwyrm/templates/directory/directory.html    |  4 ++--
 bookwyrm/urls.py                               |  2 --
 bookwyrm/views/error.py                        | 12 ------------
 5 files changed, 2 insertions(+), 16 deletions(-)
 rename bookwyrm/templates/{notfound.html => 404.html} (100%)
 rename bookwyrm/templates/{error.html => 500.html} (100%)
 delete mode 100644 bookwyrm/views/error.py

diff --git a/bookwyrm/templates/notfound.html b/bookwyrm/templates/404.html
similarity index 100%
rename from bookwyrm/templates/notfound.html
rename to bookwyrm/templates/404.html
diff --git a/bookwyrm/templates/error.html b/bookwyrm/templates/500.html
similarity index 100%
rename from bookwyrm/templates/error.html
rename to bookwyrm/templates/500.html
diff --git a/bookwyrm/templates/directory/directory.html b/bookwyrm/templates/directory/directory.html
index 7413f67d5..430e85394 100644
--- a/bookwyrm/templates/directory/directory.html
+++ b/bookwyrm/templates/directory/directory.html
@@ -44,9 +44,9 @@
         <div class="card block">
             <div class="card-content">
                 <div class="media">
-                    <span class="media-left">
+                    <a href="{{ user.local_path }}" class="media-left">
                         {% include 'snippets/avatar.html' with user=user large=True %}
-                    </span>
+                    </a>
                     <div class="media-content">
                         <a href="{{ user.local_path }}" class="is-block mb-2">
                             <span class="title is-4 is-block">{{ user.display_name }}</span>
diff --git a/bookwyrm/urls.py b/bookwyrm/urls.py
index 5d8bc5e91..33c4aaad7 100644
--- a/bookwyrm/urls.py
+++ b/bookwyrm/urls.py
@@ -23,8 +23,6 @@ status_path = r"%s/(%s)/(?P<status_id>\d+)" % (user_path, "|".join(status_types)
 
 book_path = r"^book/(?P<book_id>\d+)"
 
-handler404 = "bookwyrm.views.not_found_page"
-handler500 = "bookwyrm.views.server_error_page"
 urlpatterns = [
     path("admin/", admin.site.urls),
     path(
diff --git a/bookwyrm/views/error.py b/bookwyrm/views/error.py
deleted file mode 100644
index 9bd94ca32..000000000
--- a/bookwyrm/views/error.py
+++ /dev/null
@@ -1,12 +0,0 @@
-""" something has gone amiss """
-from django.template.response import TemplateResponse
-
-
-def server_error_page(request):
-    """ 500 errors """
-    return TemplateResponse(request, "error.html", status=500)
-
-
-def not_found_page(request, _):
-    """ 404s """
-    return TemplateResponse(request, "notfound.html", status=404)