From 33ca7b4b763c118cf84ee85205e64ccd1355b220 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 08:54:53 -0700 Subject: [PATCH 1/8] Adds datepicker script dependencies to templates --- bookwyrm/templates/author.html | 3 +++ bookwyrm/templates/book/book.html | 1 + bookwyrm/templates/book/edit_book.html | 8 ++++++-- bookwyrm/templates/book/editions.html | 4 ++++ bookwyrm/templates/edit_author.html | 4 ++++ bookwyrm/templates/feed/feed_layout.html | 1 + bookwyrm/templates/get_started/books.html | 4 ++++ bookwyrm/templates/user/layout.html | 5 +++++ 8 files changed, 28 insertions(+), 2 deletions(-) diff --git a/bookwyrm/templates/author.html b/bookwyrm/templates/author.html index bc1034a8d..0ef876fd3 100644 --- a/bookwyrm/templates/author.html +++ b/bookwyrm/templates/author.html @@ -39,3 +39,6 @@ {% endblock %} +{% block scripts %} +{% include 'snippets/datepicker_js.html' %} +{% endblock %} diff --git a/bookwyrm/templates/book/book.html b/bookwyrm/templates/book/book.html index 40da64861..53be123d8 100644 --- a/bookwyrm/templates/book/book.html +++ b/bookwyrm/templates/book/book.html @@ -333,4 +333,5 @@ {% block scripts %} +{% include 'snippets/datepicker_js.html' %} {% endblock %} diff --git a/bookwyrm/templates/book/edit_book.html b/bookwyrm/templates/book/edit_book.html index 8ebbeaae6..095439d14 100644 --- a/bookwyrm/templates/book/edit_book.html +++ b/bookwyrm/templates/book/edit_book.html @@ -133,7 +133,7 @@

- +

{% for error in form.first_published_date.errors %}

{{ error | escape }}

@@ -141,7 +141,7 @@

- +

{% for error in form.published_date.errors %}

{{ error | escape }}

@@ -245,3 +245,7 @@ {% endblock %} + +{% block scripts %} +{% include 'snippets/datepicker_js.html' %} +{% endblock %} diff --git a/bookwyrm/templates/book/editions.html b/bookwyrm/templates/book/editions.html index efbe15663..8af85aced 100644 --- a/bookwyrm/templates/book/editions.html +++ b/bookwyrm/templates/book/editions.html @@ -51,3 +51,7 @@ {% include 'snippets/pagination.html' with page=editions path=request.path %} {% endblock %} + +{% block scripts %} +{% include 'snippets/datepicker_js.html' %} +{% endblock %} diff --git a/bookwyrm/templates/edit_author.html b/bookwyrm/templates/edit_author.html index 542b57f95..ded8c4944 100644 --- a/bookwyrm/templates/edit_author.html +++ b/bookwyrm/templates/edit_author.html @@ -81,3 +81,7 @@ {% endblock %} + +{% block scripts %} +{% include 'snippets/datepicker_js.html' %} +{% endblock %} diff --git a/bookwyrm/templates/feed/feed_layout.html b/bookwyrm/templates/feed/feed_layout.html index 75fc1951a..431cf6dd7 100644 --- a/bookwyrm/templates/feed/feed_layout.html +++ b/bookwyrm/templates/feed/feed_layout.html @@ -105,4 +105,5 @@ {% block scripts %} +{% include 'snippets/datepicker_js.html' %} {% endblock %} diff --git a/bookwyrm/templates/get_started/books.html b/bookwyrm/templates/get_started/books.html index 9613508b9..e3fd87bbd 100644 --- a/bookwyrm/templates/get_started/books.html +++ b/bookwyrm/templates/get_started/books.html @@ -64,3 +64,7 @@ {% endblock %} + +{% block scripts %} +{% include 'snippets/datepicker_js.html' %} +{% endblock %} diff --git a/bookwyrm/templates/user/layout.html b/bookwyrm/templates/user/layout.html index 661d80781..1aa762027 100644 --- a/bookwyrm/templates/user/layout.html +++ b/bookwyrm/templates/user/layout.html @@ -81,3 +81,8 @@ {% block panel %}{% endblock %} {% endblock %} + + +{% block scripts %} +{% include 'snippets/datepicker_js.html' %} +{% endblock %} From 869cfa6d341f25ee25d8576adcdc2e3b8d239b9c Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 09:04:21 -0700 Subject: [PATCH 2/8] Replaces date elements with datepicker --- bookwyrm/templates/book/edit_book.html | 12 ++++++++++-- bookwyrm/templates/snippets/datepicker_js.html | 3 +++ bookwyrm/templates/snippets/readthrough_form.html | 12 ++++++++++-- .../snippets/shelve_button/finish_reading_modal.html | 12 ++++++++++-- .../snippets/shelve_button/start_reading_modal.html | 6 +++++- 5 files changed, 38 insertions(+), 7 deletions(-) create mode 100644 bookwyrm/templates/snippets/datepicker_js.html diff --git a/bookwyrm/templates/book/edit_book.html b/bookwyrm/templates/book/edit_book.html index 095439d14..644e90c6e 100644 --- a/bookwyrm/templates/book/edit_book.html +++ b/bookwyrm/templates/book/edit_book.html @@ -133,7 +133,11 @@

- +

{% for error in form.first_published_date.errors %}

{{ error | escape }}

@@ -141,7 +145,11 @@

- +

{% for error in form.published_date.errors %}

{{ error | escape }}

diff --git a/bookwyrm/templates/snippets/datepicker_js.html b/bookwyrm/templates/snippets/datepicker_js.html new file mode 100644 index 000000000..abfadaaf8 --- /dev/null +++ b/bookwyrm/templates/snippets/datepicker_js.html @@ -0,0 +1,3 @@ + + + diff --git a/bookwyrm/templates/snippets/readthrough_form.html b/bookwyrm/templates/snippets/readthrough_form.html index c5be295e1..256fcea54 100644 --- a/bookwyrm/templates/snippets/readthrough_form.html +++ b/bookwyrm/templates/snippets/readthrough_form.html @@ -5,7 +5,11 @@
{# Only show progress for editing existing readthroughs #} @@ -28,6 +32,10 @@
diff --git a/bookwyrm/templates/snippets/shelve_button/finish_reading_modal.html b/bookwyrm/templates/snippets/shelve_button/finish_reading_modal.html index ca65bf06c..6d4ea5eac 100644 --- a/bookwyrm/templates/snippets/shelve_button/finish_reading_modal.html +++ b/bookwyrm/templates/snippets/shelve_button/finish_reading_modal.html @@ -17,13 +17,21 @@
diff --git a/bookwyrm/templates/snippets/shelve_button/start_reading_modal.html b/bookwyrm/templates/snippets/shelve_button/start_reading_modal.html index 213416836..47d620e0d 100644 --- a/bookwyrm/templates/snippets/shelve_button/start_reading_modal.html +++ b/bookwyrm/templates/snippets/shelve_button/start_reading_modal.html @@ -15,7 +15,11 @@
From 748810cd419915b34849d8255fd9b4dfb71bc5fc Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 09:34:16 -0700 Subject: [PATCH 3/8] Use reverse lookups for urls --- bookwyrm/templates/book/edit_book.html | 2 +- bookwyrm/templates/book/editions.html | 4 ++-- bookwyrm/templates/discover/large-book.html | 2 +- bookwyrm/templates/discover/small-book.html | 2 +- bookwyrm/templates/edit_author.html | 2 +- bookwyrm/templates/feed/direct_messages.html | 2 +- bookwyrm/templates/import.html | 2 +- bookwyrm/templates/import_status.html | 2 +- bookwyrm/templates/layout.html | 12 ++++++------ bookwyrm/templates/login.html | 4 ++-- bookwyrm/templates/notifications.html | 2 +- .../preferences/preferences_layout.html | 9 ++++++--- bookwyrm/templates/snippets/authors.html | 2 +- bookwyrm/templates/snippets/book_tiles.html | 2 +- bookwyrm/templates/snippets/status/layout.html | 2 +- .../templates/snippets/status/status_header.html | 8 ++++---- bookwyrm/templates/snippets/user_options.html | 2 +- bookwyrm/urls.py | 16 ++++++++++------ 18 files changed, 42 insertions(+), 35 deletions(-) diff --git a/bookwyrm/templates/book/edit_book.html b/bookwyrm/templates/book/edit_book.html index 8ebbeaae6..bcf111267 100644 --- a/bookwyrm/templates/book/edit_book.html +++ b/bookwyrm/templates/book/edit_book.html @@ -239,7 +239,7 @@ {% if not confirm_mode %}
- {% trans "Cancel" %} + {% trans "Cancel" %}
{% endif %} diff --git a/bookwyrm/templates/book/editions.html b/bookwyrm/templates/book/editions.html index efbe15663..775b05c86 100644 --- a/bookwyrm/templates/book/editions.html +++ b/bookwyrm/templates/book/editions.html @@ -15,14 +15,14 @@ {% for book in editions %}
- + {% include 'snippets/book_cover.html' with book=book cover_class='is-w-m is-h-m align to-l-mobile' %}

- + {{ book.title }}

diff --git a/bookwyrm/templates/discover/large-book.html b/bookwyrm/templates/discover/large-book.html index 1808a0f9d..7def6e138 100644 --- a/bookwyrm/templates/discover/large-book.html +++ b/bookwyrm/templates/discover/large-book.html @@ -17,7 +17,7 @@

- {{ book.title }} + {{ book.title }}

{% if book.authors %} diff --git a/bookwyrm/templates/discover/small-book.html b/bookwyrm/templates/discover/small-book.html index ad7e00fba..73133de45 100644 --- a/bookwyrm/templates/discover/small-book.html +++ b/bookwyrm/templates/discover/small-book.html @@ -11,7 +11,7 @@ {% include 'snippets/stars.html' with rating=book|rating:request.user %}

- {{ book.title }} + {{ book.title }}

{% if book.authors %} diff --git a/bookwyrm/templates/edit_author.html b/bookwyrm/templates/edit_author.html index 542b57f95..b575bbb2f 100644 --- a/bookwyrm/templates/edit_author.html +++ b/bookwyrm/templates/edit_author.html @@ -76,7 +76,7 @@
- {% trans "Cancel" %} + {% trans "Cancel" %}
diff --git a/bookwyrm/templates/feed/direct_messages.html b/bookwyrm/templates/feed/direct_messages.html index 1e361e614..0b7dcd79c 100644 --- a/bookwyrm/templates/feed/direct_messages.html +++ b/bookwyrm/templates/feed/direct_messages.html @@ -10,7 +10,7 @@ {% trans "Direct Messages" %} {% endif %} - {% if partner %}

{% trans "All messages" %}

{% endif %} + {% if partner %}

{% trans "All messages" %}

{% endif %}
diff --git a/bookwyrm/templates/import.html b/bookwyrm/templates/import.html index 239b6914d..c4f0dfae4 100644 --- a/bookwyrm/templates/import.html +++ b/bookwyrm/templates/import.html @@ -56,7 +56,7 @@ {% endif %}
diff --git a/bookwyrm/templates/import_status.html b/bookwyrm/templates/import_status.html index 3ce929e6a..e06392a8e 100644 --- a/bookwyrm/templates/import_status.html +++ b/bookwyrm/templates/import_status.html @@ -124,7 +124,7 @@ {% if item.book %} - + {% include 'snippets/book_cover.html' with book=item.book cover_class='is-h-s' %} {% endif %} diff --git a/bookwyrm/templates/layout.html b/bookwyrm/templates/layout.html index c45f23804..bc6544012 100644 --- a/bookwyrm/templates/layout.html +++ b/bookwyrm/templates/layout.html @@ -94,12 +94,12 @@
  • - + {% trans 'Import Books' %}
  • - + {% trans 'Settings' %}
    • @@ -122,14 +122,14 @@ {% endif %}
  • - + {% trans 'Log out' %}
    • - + {% trans "Notifications" %} @@ -158,7 +158,7 @@
    -

    {% trans "Forgot your password?" %}

    +

    {% trans "Forgot your password?" %}

    @@ -195,7 +195,7 @@

    - {% trans "About this server" %} + {% trans "About this server" %}

    {% if site.admin_email %}

    diff --git a/bookwyrm/templates/login.html b/bookwyrm/templates/login.html index 063b4b6dd..8ed5d0447 100644 --- a/bookwyrm/templates/login.html +++ b/bookwyrm/templates/login.html @@ -33,7 +33,7 @@

    - {% trans "Forgot your password?" %} + {% trans "Forgot your password?" %}
    @@ -56,7 +56,7 @@ {% include 'snippets/about.html' %}

    - {% trans "More about this site" %} + {% trans "More about this site" %}

    diff --git a/bookwyrm/templates/notifications.html b/bookwyrm/templates/notifications.html index ba0a25cd0..73ad23b8a 100644 --- a/bookwyrm/templates/notifications.html +++ b/bookwyrm/templates/notifications.html @@ -107,7 +107,7 @@ {% endif %} {% endif %} {% elif notification.related_import %} - {% blocktrans with related_id=notification.related_import.id %}Your import completed.{% endblocktrans %} + {% blocktrans with related_id=notification.related_import.id %}Your import completed.{% endblocktrans %} {% elif notification.related_report %} {% url 'settings-report' notification.related_report.id as path %} {% blocktrans with related_id=path %}A new report needs moderation.{% endblocktrans %} diff --git a/bookwyrm/templates/preferences/preferences_layout.html b/bookwyrm/templates/preferences/preferences_layout.html index d463d9cba..baf87e478 100644 --- a/bookwyrm/templates/preferences/preferences_layout.html +++ b/bookwyrm/templates/preferences/preferences_layout.html @@ -11,16 +11,19 @@

    {% trans "Account" %}

    {% trans "Relationships" %}

    diff --git a/bookwyrm/templates/snippets/authors.html b/bookwyrm/templates/snippets/authors.html index 9459b0fe4..476956b6e 100644 --- a/bookwyrm/templates/snippets/authors.html +++ b/bookwyrm/templates/snippets/authors.html @@ -5,7 +5,7 @@ {% endcomment %} {% for author in book.authors.all %}
    + {% include 'snippets/book_cover.html' with book=book cover_class='is-w-l-mobile is-h-l-mobile is-w-l-tablet is-h-xl-tablet' %}
    diff --git a/bookwyrm/templates/snippets/status/layout.html b/bookwyrm/templates/snippets/status/layout.html index 6014158ff..ddbd6f20f 100644 --- a/bookwyrm/templates/snippets/status/layout.html +++ b/bookwyrm/templates/snippets/status/layout.html @@ -44,7 +44,7 @@ {% else %}
    - + {% trans "Reply" %} diff --git a/bookwyrm/templates/snippets/status/status_header.html b/bookwyrm/templates/snippets/status/status_header.html index b9faf64e6..605b46cce 100644 --- a/bookwyrm/templates/snippets/status/status_header.html +++ b/bookwyrm/templates/snippets/status/status_header.html @@ -47,7 +47,7 @@ {% if status.book %} {% if status.status_type == 'GeneratedNote' or status.status_type == 'Rating' %} - {{ status.book|title }}{% if status.status_type == 'Rating' %}: {% include 'snippets/stars.html' with rating=status.rating %} + {{ status.book|title }}{% if status.status_type == 'Rating' %}: {% include 'snippets/stars.html' with rating=status.rating %} {{ status.book|title }}{% if status.status_type == 'Rating' %}: + {{ status.book|title }}{% if status.status_type == 'Rating' %}: + {{ status.mention_books.first.title }} {% endif %} @@ -86,7 +86,7 @@ {% include 'snippets/book_titleby.html' with book=status.book %} {% endif %} {% elif status.mention_books %} - {{ status.mention_books.first|title }} + {{ status.mention_books.first|title }} {% endif %} diff --git a/bookwyrm/templates/snippets/user_options.html b/bookwyrm/templates/snippets/user_options.html index ec772e54b..32e83ed2c 100644 --- a/bookwyrm/templates/snippets/user_options.html +++ b/bookwyrm/templates/snippets/user_options.html @@ -10,7 +10,7 @@ {% block dropdown-list %}
  • - {% trans "Send direct message" %} + {% trans "Send direct message" %}
  • {% include 'snippets/report_button.html' with user=user class="is-fullwidth" %} diff --git a/bookwyrm/urls.py b/bookwyrm/urls.py index 14fe476d4..3e7dea58a 100644 --- a/bookwyrm/urls.py +++ b/bookwyrm/urls.py @@ -45,8 +45,12 @@ urlpatterns = [ # authentication re_path(r"^login/?$", views.Login.as_view(), name="login"), re_path(r"^register/?$", views.Register.as_view()), - re_path(r"^logout/?$", views.Logout.as_view()), - re_path(r"^password-reset/?$", views.PasswordResetRequest.as_view()), + re_path(r"^logout/?$", views.Logout.as_view(), name="logout"), + re_path( + r"^password-reset/?$", + views.PasswordResetRequest.as_view(), + name="password-reset", + ), re_path( r"^password-reset/(?P[A-Za-z0-9]+)/?$", views.PasswordReset.as_view() ), @@ -134,7 +138,7 @@ urlpatterns = [ re_path(r"^about/?$", views.About.as_view(), name="about"), path("", views.Home.as_view(), name="landing"), re_path(r"^discover/?$", views.Discover.as_view()), - re_path(r"^notifications/?$", views.Notifications.as_view()), + re_path(r"^notifications/?$", views.Notifications.as_view(), name="notifications"), re_path(r"^directory/?", views.Directory.as_view(), name="directory"), # Get started re_path( @@ -165,8 +169,8 @@ urlpatterns = [ # search re_path(r"^search/?$", views.Search.as_view(), name="search"), # imports - re_path(r"^import/?$", views.Import.as_view()), - re_path(r"^import/(\d+)/?$", views.ImportStatus.as_view()), + re_path(r"^import/?$", views.Import.as_view(), name="import"), + re_path(r"^import/(\d+)/?$", views.ImportStatus.as_view(), name="import-status"), # users re_path(r"%s/?$" % user_path, views.User.as_view(), name="user-feed"), re_path(r"%s\.json$" % user_path, views.User.as_view()), @@ -229,7 +233,7 @@ urlpatterns = [ views.ChangePassword.as_view(), name="prefs-password", ), - re_path(r"^preferences/block/?$", views.Block.as_view()), + re_path(r"^preferences/block/?$", views.Block.as_view(), name="prefs-block"), re_path(r"^block/(?P\d+)/?$", views.Block.as_view()), re_path(r"^unblock/(?P\d+)/?$", views.unblock), # statuses From 7bbef1d193ab0344d70ec7b75930d2ab6fa8d947 Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 09:42:00 -0700 Subject: [PATCH 4/8] Removes outdated test --- bookwyrm/tests/views/test_book.py | 33 ------------------------------- 1 file changed, 33 deletions(-) diff --git a/bookwyrm/tests/views/test_book.py b/bookwyrm/tests/views/test_book.py index dce50868f..2acdb369f 100644 --- a/bookwyrm/tests/views/test_book.py +++ b/bookwyrm/tests/views/test_book.py @@ -47,39 +47,6 @@ class BookViews(TestCase): ) models.SiteSettings.objects.create() - def test_date_regression(self): - """ensure that creating a new book actually saves the published date fields - - this was initially a regression due to using a custom date picker tag - """ - first_published_date = "2021-04-20" - published_date = "2022-04-20" - self.local_user.groups.add(self.group) - view = views.EditBook.as_view() - form = forms.EditionForm( - { - "title": "New Title", - "last_edited_by": self.local_user.id, - "first_published_date": first_published_date, - "published_date": published_date, - } - ) - request = self.factory.post("", form.data) - request.user = self.local_user - - with patch("bookwyrm.connectors.connector_manager.local_search"): - result = view(request) - result.render() - - self.assertContains( - result, - f'', - ) - self.assertContains( - result, - f'', - ) - def test_book_page(self): """there are so many views, this just makes sure it LOADS""" view = views.Book.as_view() From 906201fa2ad617fd0072617b6d3475eb8a2aa56a Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 09:45:13 -0700 Subject: [PATCH 5/8] Fixes notification import link --- bookwyrm/templates/notifications.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bookwyrm/templates/notifications.html b/bookwyrm/templates/notifications.html index 73ad23b8a..8f8fede2f 100644 --- a/bookwyrm/templates/notifications.html +++ b/bookwyrm/templates/notifications.html @@ -107,7 +107,8 @@ {% endif %} {% endif %} {% elif notification.related_import %} - {% blocktrans with related_id=notification.related_import.id %}Your import completed.{% endblocktrans %} + {% url 'import-status' notification.related_import.id as url %} + {% blocktrans %}Your import completed.{% endblocktrans %} {% elif notification.related_report %} {% url 'settings-report' notification.related_report.id as path %} {% blocktrans with related_id=path %}A new report needs moderation.{% endblocktrans %} From c9ed069121eaef14e2af1d8e9b25d689debd846f Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 09:47:00 -0700 Subject: [PATCH 6/8] Use example url in test --- bookwyrm/tests/views/inbox/test_inbox_add.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/bookwyrm/tests/views/inbox/test_inbox_add.py b/bookwyrm/tests/views/inbox/test_inbox_add.py index 9f237b6db..8d1c493f7 100644 --- a/bookwyrm/tests/views/inbox/test_inbox_add.py +++ b/bookwyrm/tests/views/inbox/test_inbox_add.py @@ -35,7 +35,7 @@ class InboxAdd(TestCase): work = models.Work.objects.create(title="work title") self.book = models.Edition.objects.create( title="Test", - remote_id="https://bookwyrm.social/book/37292", + remote_id="https://example.com/book/37292", parent_work=work, ) @@ -44,20 +44,20 @@ class InboxAdd(TestCase): def test_handle_add_book_to_shelf(self): """shelving a book""" shelf = models.Shelf.objects.create(user=self.remote_user, name="Test Shelf") - shelf.remote_id = "https://bookwyrm.social/user/mouse/shelf/to-read" + shelf.remote_id = "https://example.com/user/mouse/shelf/to-read" shelf.save() activity = { - "id": "https://bookwyrm.social/shelfbook/6189#add", + "id": "https://bookwyrm.l/shelfbook/6189#add", "type": "Add", "actor": "https://example.com/users/rat", "object": { "actor": self.remote_user.remote_id, "type": "ShelfItem", "book": self.book.remote_id, - "id": "https://bookwyrm.social/shelfbook/6189", + "id": "https://example.com/shelfbook/6189", }, - "target": "https://bookwyrm.social/user/mouse/shelf/to-read", + "target": "https://example.com/user/mouse/shelf/to-read", "@context": "https://www.w3.org/ns/activitystreams", } views.inbox.activity_task(activity) @@ -68,7 +68,7 @@ class InboxAdd(TestCase): """listing a book""" responses.add( responses.GET, - "https://bookwyrm.social/user/mouse/list/to-read", + "https://example.com/user/mouse/list/to-read", json={ "id": "https://example.com/list/22", "type": "BookList", @@ -86,17 +86,17 @@ class InboxAdd(TestCase): ) activity = { - "id": "https://bookwyrm.social/listbook/6189#add", + "id": "https://example.com/listbook/6189#add", "type": "Add", "actor": "https://example.com/users/rat", "object": { "actor": self.remote_user.remote_id, "type": "ListItem", "book": self.book.remote_id, - "id": "https://bookwyrm.social/listbook/6189", + "id": "https://example.com/listbook/6189", "order": 1, }, - "target": "https://bookwyrm.social/user/mouse/list/to-read", + "target": "https://example.com/user/mouse/list/to-read", "@context": "https://www.w3.org/ns/activitystreams", } views.inbox.activity_task(activity) @@ -105,4 +105,4 @@ class InboxAdd(TestCase): listitem = models.ListItem.objects.get() self.assertEqual(booklist.name, "Test List") self.assertEqual(booklist.books.first(), self.book) - self.assertEqual(listitem.remote_id, "https://bookwyrm.social/listbook/6189") + self.assertEqual(listitem.remote_id, "https://example.com/listbook/6189") From b10f0b19c4ed6e5f34df60431318dcabba35ce5a Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 09:49:24 -0700 Subject: [PATCH 7/8] Removes outdated test --- bookwyrm/tests/views/test_book.py | 33 ------------------------------- 1 file changed, 33 deletions(-) diff --git a/bookwyrm/tests/views/test_book.py b/bookwyrm/tests/views/test_book.py index dce50868f..2acdb369f 100644 --- a/bookwyrm/tests/views/test_book.py +++ b/bookwyrm/tests/views/test_book.py @@ -47,39 +47,6 @@ class BookViews(TestCase): ) models.SiteSettings.objects.create() - def test_date_regression(self): - """ensure that creating a new book actually saves the published date fields - - this was initially a regression due to using a custom date picker tag - """ - first_published_date = "2021-04-20" - published_date = "2022-04-20" - self.local_user.groups.add(self.group) - view = views.EditBook.as_view() - form = forms.EditionForm( - { - "title": "New Title", - "last_edited_by": self.local_user.id, - "first_published_date": first_published_date, - "published_date": published_date, - } - ) - request = self.factory.post("", form.data) - request.user = self.local_user - - with patch("bookwyrm.connectors.connector_manager.local_search"): - result = view(request) - result.render() - - self.assertContains( - result, - f'', - ) - self.assertContains( - result, - f'', - ) - def test_book_page(self): """there are so many views, this just makes sure it LOADS""" view = views.Book.as_view() From 5906588c860796ee2f000bb364697f8a2ce29fec Mon Sep 17 00:00:00 2001 From: Mouse Reeve Date: Tue, 4 May 2021 10:33:16 -0700 Subject: [PATCH 8/8] Fixes shelf add test --- bookwyrm/tests/views/inbox/test_inbox_add.py | 26 +++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/bookwyrm/tests/views/inbox/test_inbox_add.py b/bookwyrm/tests/views/inbox/test_inbox_add.py index 8d1c493f7..5f86b1215 100644 --- a/bookwyrm/tests/views/inbox/test_inbox_add.py +++ b/bookwyrm/tests/views/inbox/test_inbox_add.py @@ -41,14 +41,34 @@ class InboxAdd(TestCase): models.SiteSettings.objects.create() + @responses.activate def test_handle_add_book_to_shelf(self): """shelving a book""" shelf = models.Shelf.objects.create(user=self.remote_user, name="Test Shelf") - shelf.remote_id = "https://example.com/user/mouse/shelf/to-read" + shelf.remote_id = "https://example.com/user/rat/shelf/to-read" shelf.save() + responses.add( + responses.GET, + "https://example.com/user/rat/shelf/to-read", + json={ + "id": shelf.remote_id, + "type": "Shelf", + "totalItems": 1, + "first": "https://example.com/shelf/22?page=1", + "last": "https://example.com/shelf/22?page=1", + "name": "Test Shelf", + "owner": self.remote_user.remote_id, + "to": ["https://www.w3.org/ns/activitystreams#Public"], + "cc": ["https://example.com/user/rat/followers"], + "summary": "summary text", + "curation": "curated", + "@context": "https://www.w3.org/ns/activitystreams", + }, + ) + activity = { - "id": "https://bookwyrm.l/shelfbook/6189#add", + "id": "https://example.com/shelfbook/6189#add", "type": "Add", "actor": "https://example.com/users/rat", "object": { @@ -57,7 +77,7 @@ class InboxAdd(TestCase): "book": self.book.remote_id, "id": "https://example.com/shelfbook/6189", }, - "target": "https://example.com/user/mouse/shelf/to-read", + "target": "https://example.com/user/rat/shelf/to-read", "@context": "https://www.w3.org/ns/activitystreams", } views.inbox.activity_task(activity)