From e4be6a98e8263983c96b696bc63227cf259049f5 Mon Sep 17 00:00:00 2001
From: Hugh Rundle <hugh@hughrundle.net>
Date: Fri, 7 Jan 2022 13:13:56 +1100
Subject: [PATCH 1/2] do not cache registration form

Fixes #1777

Caching the Landing view also caches the registration form, including the CSRF value.

This moves the caching into the recently reviewed books landing template which is presumably what we're trying to cache here, instead of caching the whole view.

NOTE: this fixes the problem with registration, I haven't done enough testing to be sure it actually still caches the recent reviews data.
---
 bookwyrm/templates/landing/landing.html | 4 +++-
 bookwyrm/views/landing/landing.py       | 1 -
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/bookwyrm/templates/landing/landing.html b/bookwyrm/templates/landing/landing.html
index d13cd582a..759e8c619 100644
--- a/bookwyrm/templates/landing/landing.html
+++ b/bookwyrm/templates/landing/landing.html
@@ -1,11 +1,13 @@
 {% extends 'landing/layout.html' %}
 {% load i18n %}
+{% load cache %}
 {% block panel %}
 
 <div class="block is-hidden-tablet">
     <h2 class="title has-text-centered">{% trans "Recent Books" %}</h2>
 </div>
 
+{% cache 60 * 60 %}
 <section class="tile is-ancestor">
     <div class="tile is-vertical is-6">
         <div class="tile is-parent">
@@ -46,5 +48,5 @@
         </div>
     </div>
 </section>
-
+{% endcache %}
 {% endblock %}
diff --git a/bookwyrm/views/landing/landing.py b/bookwyrm/views/landing/landing.py
index 74b5ee513..5839731d5 100644
--- a/bookwyrm/views/landing/landing.py
+++ b/bookwyrm/views/landing/landing.py
@@ -33,7 +33,6 @@ class Home(View):
 class Landing(View):
     """preview of recently reviewed books"""
 
-    @method_decorator(cache_page(60 * 60), name="dispatch")
     def get(self, request):
         """tiled book activity page"""
         data = {

From a1e3ef1c79c0d9ac5165d7562a9203eb97e8ccfe Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Thu, 6 Jan 2022 18:47:14 -0800
Subject: [PATCH 2/2] Fixes pylint complaint

---
 bookwyrm/views/landing/landing.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/bookwyrm/views/landing/landing.py b/bookwyrm/views/landing/landing.py
index 5839731d5..c8bba0664 100644
--- a/bookwyrm/views/landing/landing.py
+++ b/bookwyrm/views/landing/landing.py
@@ -1,8 +1,6 @@
 """ non-interactive pages """
 from django.template.response import TemplateResponse
 from django.views import View
-from django.utils.decorators import method_decorator
-from django.views.decorators.cache import cache_page
 
 from bookwyrm import forms
 from bookwyrm.views import helpers