From 074c2cfb957b0b4cb3851cc79fc8917b62263856 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Thu, 9 Dec 2021 18:16:34 -0800
Subject: [PATCH] Gets updates view to 100% test coverage

---
 bookwyrm/tests/views/test_updates.py | 11 ++++++++++-
 bookwyrm/views/updates.py            |  4 ++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/bookwyrm/tests/views/test_updates.py b/bookwyrm/tests/views/test_updates.py
index d5d1d8811..4ca704fcf 100644
--- a/bookwyrm/tests/views/test_updates.py
+++ b/bookwyrm/tests/views/test_updates.py
@@ -2,7 +2,7 @@
 import json
 from unittest.mock import patch
 
-from django.http import JsonResponse
+from django.http import Http404, JsonResponse
 from django.test import TestCase
 from django.test.client import RequestFactory
 
@@ -54,6 +54,7 @@ class UpdateViews(TestCase):
             "bookwyrm.activitystreams.ActivityStream.get_unread_count"
         ) as mock_count:
             with patch(
+                # pylint:disable=line-too-long
                 "bookwyrm.activitystreams.ActivityStream.get_unread_count_by_status_type"
             ) as mock_count_by_status:
                 mock_count.return_value = 3
@@ -64,3 +65,11 @@ class UpdateViews(TestCase):
         data = json.loads(result.getvalue())
         self.assertEqual(data["count"], 3)
         self.assertEqual(data["count_by_type"]["review"], 5)
+
+    def test_get_unread_status_count_invalid_stream(self):
+        """there are so many views, this just makes sure it LOADS"""
+        request = self.factory.get("")
+        request.user = self.local_user
+
+        with self.assertRaises(Http404):
+            views.get_unread_status_count(request, "fish")
diff --git a/bookwyrm/views/updates.py b/bookwyrm/views/updates.py
index 2bbc54776..765865ef5 100644
--- a/bookwyrm/views/updates.py
+++ b/bookwyrm/views/updates.py
@@ -1,6 +1,6 @@
 """ endpoints for getting updates about activity """
 from django.contrib.auth.decorators import login_required
-from django.http import JsonResponse
+from django.http import Http404, JsonResponse
 
 from bookwyrm import activitystreams
 
@@ -21,7 +21,7 @@ def get_unread_status_count(request, stream="home"):
     """any unread statuses for this feed?"""
     stream = activitystreams.streams.get(stream)
     if not stream:
-        return JsonResponse({})
+        raise Http404
     return JsonResponse(
         {
             "count": stream.get_unread_count(request.user),