From 0013ab509754fefa36ea636dffec5795d1e3496d Mon Sep 17 00:00:00 2001
From: Rob Ede <robjtede@icloud.com>
Date: Mon, 30 Oct 2023 00:36:06 +0000
Subject: [PATCH] temp demonstrate failure

---
 .github/workflows/lint.yml |  2 +-
 awc/Cargo.toml             |  2 +-
 justfile                   | 12 ++++++------
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index e71153c43..abcbebd04 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -81,7 +81,7 @@ jobs:
           tool: cargo-check-external-types@0.1.10
 
       - name: check external types
-        run: just check-external-types-all
+        run: just check-external-types-all +nightly-2023-10-10
 
   public-api-diff:
     runs-on: ubuntu-latest
diff --git a/awc/Cargo.toml b/awc/Cargo.toml
index 67c90df88..f1bfa1380 100644
--- a/awc/Cargo.toml
+++ b/awc/Cargo.toml
@@ -21,7 +21,7 @@ features = ["openssl", "rustls-0_20", "rustls-0_21", "compress-brotli", "compres
 
 [package.metadata.cargo_check_external_types]
 allowed_external_types = [
-    "actix_codec::*",
+    # "actix_codec::*",
     "actix_http::*",
     "actix_rt::*",
     "actix_service::*",
diff --git a/justfile b/justfile
index 3895e03de..72331f9ee 100644
--- a/justfile
+++ b/justfile
@@ -11,27 +11,27 @@ doc-watch:
     cargo watch -- RUSTDOCFLAGS="--cfg=docsrs" cargo +nightly doc --no-deps --workspace --features=rustls,openssl
 
 # Check for unintentional external type exposure on all crates in workspace.
-check-external-types-all:
+check-external-types-all toolchain="+nightly":
     #!/usr/bin/env bash
     set -euo pipefail
     exit=0
     for f in $(find . -mindepth 2 -maxdepth 2 -name Cargo.toml | grep -vE "\-codegen/|\-derive/|\-macros/"); do
-        if ! just check-external-types-manifest "$f"; then exit=1; fi
+        if ! just check-external-types-manifest "$f" {{toolchain}}; then exit=1; fi
         echo
         echo
     done
     exit $exit
 
 # Check for unintentional external type exposure on all crates in workspace.
-check-external-types-all-table:
+check-external-types-all-table toolchain="+nightly":
     #!/usr/bin/env bash
     set -euo pipefail
     for f in $(find . -mindepth 2 -maxdepth 2 -name Cargo.toml | grep -vE "\-codegen/|\-derive/|\-macros/"); do
         echo
         echo "Checking for $f"
-        just check-external-types-manifest "$f" --output-format=markdown-table
+        just check-external-types-manifest "$f" {{toolchain}} --output-format=markdown-table
     done
 
 # Check for unintentional external type exposure on a crate.
-check-external-types-manifest manifest_path *extra_args:
-    cargo +nightly check-external-types --manifest-path "{{manifest_path}}" {{extra_args}}
+check-external-types-manifest manifest_path toolchain="+nightly" *extra_args="":
+    cargo {{toolchain}} check-external-types --manifest-path "{{manifest_path}}" {{extra_args}}