diff --git a/server.ts b/server.ts index ad162832b..559327f16 100644 --- a/server.ts +++ b/server.ts @@ -221,18 +221,18 @@ app.use('/', downloadRouter) app.use('/', lazyStaticRouter) // Client files, last valid routes! -const cliOptions = cli.opts() +const cliOptions = cli.opts<{ client: boolean, plugins: boolean }>() if (cliOptions.client) app.use('/', clientsRouter) // ----------- Errors ----------- // Catch unmatched routes -app.use((req, res: express.Response) => { +app.use((_req, res: express.Response) => { res.status(HttpStatusCode.NOT_FOUND_404).end() }) // Catch thrown errors -app.use((err, req, res: express.Response, next) => { +app.use((err, _req, res: express.Response, _next) => { // Format error to be logged let error = 'Unknown error.' if (err) { diff --git a/server/helpers/audit-logger.ts b/server/helpers/audit-logger.ts index 79ef44be1..076b7f11d 100644 --- a/server/helpers/audit-logger.ts +++ b/server/helpers/audit-logger.ts @@ -120,7 +120,7 @@ const videoKeysToKeep = [ 'downloadEnabled' ] class VideoAuditView extends EntityAuditView { - constructor (private readonly video: VideoDetails) { + constructor (video: VideoDetails) { super(videoKeysToKeep, 'video', video) } } @@ -131,7 +131,7 @@ const videoImportKeysToKeep = [ 'video-name' ] class VideoImportAuditView extends EntityAuditView { - constructor (private readonly videoImport: VideoImport) { + constructor (videoImport: VideoImport) { super(videoImportKeysToKeep, 'video-import', videoImport) } } @@ -150,7 +150,7 @@ const commentKeysToKeep = [ 'account-name' ] class CommentAuditView extends EntityAuditView { - constructor (private readonly comment: VideoComment) { + constructor (comment: VideoComment) { super(commentKeysToKeep, 'comment', comment) } } @@ -179,7 +179,7 @@ const userKeysToKeep = [ 'videoChannels' ] class UserAuditView extends EntityAuditView { - constructor (private readonly user: User) { + constructor (user: User) { super(userKeysToKeep, 'user', user) } } @@ -205,7 +205,7 @@ const channelKeysToKeep = [ 'ownerAccount-displayedName' ] class VideoChannelAuditView extends EntityAuditView { - constructor (private readonly channel: VideoChannel) { + constructor (channel: VideoChannel) { super(channelKeysToKeep, 'channel', channel) } } @@ -217,7 +217,7 @@ const abuseKeysToKeep = [ 'createdAt' ] class AbuseAuditView extends EntityAuditView { - constructor (private readonly abuse: AdminAbuse) { + constructor (abuse: AdminAbuse) { super(abuseKeysToKeep, 'abuse', abuse) } } diff --git a/tsconfig.base.json b/tsconfig.base.json index b54d5a556..18ba8f06c 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -8,7 +8,6 @@ "emitDecoratorMetadata": true, "importHelpers": true, "removeComments": true, - "strictBindCallApply": true, "esModuleInterop": true, "forceConsistentCasingInFileNames": true, "lib": [ @@ -27,6 +26,11 @@ }, "resolveJsonModule": true, "strict": false, + "strictBindCallApply": true, + "allowUnreachableCode": false, + "allowUnusedLabels": false, + "noFallthroughCasesInSwitch": true, + "noUnusedLocals": true, "skipLibCheck": true, "composite": true, "declarationMap": true