From d0c2cd4520d1767a65f27a1e923c27d10782e412 Mon Sep 17 00:00:00 2001
From: Thomas Ricouard <ricouard77@gmail.com>
Date: Thu, 28 Dec 2023 11:54:41 +0100
Subject: [PATCH] Better unread counter + animation

---
 .../Timeline/PendingStatusesObserver.swift      | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/Packages/Timeline/Sources/Timeline/PendingStatusesObserver.swift b/Packages/Timeline/Sources/Timeline/PendingStatusesObserver.swift
index baac37ab..d5a307dd 100644
--- a/Packages/Timeline/Sources/Timeline/PendingStatusesObserver.swift
+++ b/Packages/Timeline/Sources/Timeline/PendingStatusesObserver.swift
@@ -3,6 +3,7 @@ import Foundation
 import Models
 import Observation
 import SwiftUI
+import DesignSystem
 
 @MainActor
 @Observable class PendingStatusesObserver {
@@ -13,7 +14,9 @@ import SwiftUI
 
   var pendingStatuses: [String] = [] {
     didSet {
-      pendingStatusesCount = pendingStatuses.count
+      withAnimation(.default) {
+        pendingStatusesCount = pendingStatuses.count
+      }
     }
   }
 
@@ -30,14 +33,18 @@ import SwiftUI
 struct PendingStatusesObserverView: View {
   @State var observer: PendingStatusesObserver
   @Environment(UserPreferences.self) private var preferences
+  @Environment(Theme.self) private var theme
+  
   var body: some View {
     if observer.pendingStatusesCount > 0 {
       Button {
         observer.scrollToIndex?(observer.pendingStatusesCount)
       } label: {
         Text("\(observer.pendingStatusesCount)")
+          .contentTransition(.numericText(countsDown: true))
           // Accessibility: this results in a frame with a size of at least 44x44 at regular font size
-          .frame(minWidth: 30, minHeight: 30)
+          .frame(minWidth: 16, minHeight: 16)
+          .font(.footnote)
       }
       .accessibilityLabel("accessibility.tabs.timeline.unread-posts.label-\(observer.pendingStatusesCount)")
       .accessibilityHint("accessibility.tabs.timeline.unread-posts.hint")
@@ -49,7 +56,11 @@ struct PendingStatusesObserverView: View {
       .background(.thinMaterial)
       #endif
       .cornerRadius(8)
-      .padding(12)
+      .overlay(
+        RoundedRectangle(cornerRadius: 8)
+          .stroke(theme.tintColor, lineWidth: 1)
+      )
+      .padding(8)
       .frame(maxWidth: .infinity, maxHeight: .infinity, alignment: preferences.pendingLocation)
     }
   }