mirrors/IceCubesApp
1
0
Fork 0
mirror of https://github.com/Dimillian/IceCubesApp.git synced 2024-11-23 00:40:59 +00:00
Code Issues Projects Releases Packages Wiki Activity
IceCubesApp/Packages/Models/Tests/ModelsTests/HTMLStringTests.swift

89 lines
5 KiB
Swift
Raw Normal View History

Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
@testable import Models
import XCTest
final class HTMLStringTests: XCTestCase {
func testURLInit() throws {
XCTAssertNil(URL(string: "", encodePath: true))
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let simpleUrl = URL(string: "https://www.google.com", encodePath: true)
XCTAssertEqual("https://www.google.com", simpleUrl?.absoluteString)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let urlWithTrailingSlash = URL(string: "https://www.google.com/", encodePath: true)
XCTAssertEqual("https://www.google.com/", urlWithTrailingSlash?.absoluteString)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let extendedCharPath = URL(string: "https://en.wikipedia.org/wiki/Elbbrücken_station", encodePath: true)
XCTAssertEqual("https://en.wikipedia.org/wiki/Elbbr%C3%BCcken_station", extendedCharPath?.absoluteString)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let extendedCharQuery = URL(string: "http://test.com/blah/city?name=京都市", encodePath: true)
XCTAssertEqual("http://test.com/blah/city?name=%E4%BA%AC%E9%83%BD%E5%B8%82", extendedCharQuery?.absoluteString)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
// Double encoding will happen if you ask to encodePath on an already encoded string
let alreadyEncodedPath = URL(string: "https://en.wikipedia.org/wiki/Elbbr%C3%BCcken_station", encodePath: true)
XCTAssertEqual("https://en.wikipedia.org/wiki/Elbbr%25C3%25BCcken_station", alreadyEncodedPath?.absoluteString)
}
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
func testHTMLStringInit() throws {
let decoder = JSONDecoder()
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let basicContent = "\"<p>This is a test</p>\""
var htmlString = try decoder.decode(HTMLString.self, from: Data(basicContent.utf8))
XCTAssertEqual("This is a test", htmlString.asRawText)
XCTAssertEqual("<p>This is a test</p>", htmlString.htmlValue)
XCTAssertEqual("This is a test", htmlString.asMarkdown)
XCTAssertEqual(0, htmlString.statusesURLs.count)
XCTAssertEqual(0, htmlString.links.count)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let basicLink = "\"<p>This is a <a href=\\\"https://test.com\\\">test</a></p>\""
htmlString = try decoder.decode(HTMLString.self, from: Data(basicLink.utf8))
XCTAssertEqual("This is a test", htmlString.asRawText)
XCTAssertEqual("<p>This is a <a href=\"https://test.com\">test</a></p>", htmlString.htmlValue)
XCTAssertEqual("This is a [test](https://test.com)", htmlString.asMarkdown)
XCTAssertEqual(0, htmlString.statusesURLs.count)
XCTAssertEqual(1, htmlString.links.count)
XCTAssertEqual("https://test.com", htmlString.links[0].url.absoluteString)
XCTAssertEqual("test", htmlString.links[0].displayString)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let extendedCharLink = "\"<p>This is a <a href=\\\"https://test.com/goßëña\\\">test</a></p>\""
htmlString = try decoder.decode(HTMLString.self, from: Data(extendedCharLink.utf8))
XCTAssertEqual("This is a test", htmlString.asRawText)
XCTAssertEqual("<p>This is a <a href=\"https://test.com/goßëña\">test</a></p>", htmlString.htmlValue)
XCTAssertEqual("This is a [test](https://test.com/go%C3%9F%C3%AB%C3%B1a)", htmlString.asMarkdown)
XCTAssertEqual(0, htmlString.statusesURLs.count)
XCTAssertEqual(1, htmlString.links.count)
XCTAssertEqual("https://test.com/go%C3%9F%C3%AB%C3%B1a", htmlString.links[0].url.absoluteString)
XCTAssertEqual("test", htmlString.links[0].displayString)
Swiftformat
2023-09-16 12:15:03 +00:00
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
let alreadyEncodedLink = "\"<p>This is a <a href=\\\"https://test.com/go%C3%9F%C3%AB%C3%B1a\\\">test</a></p>\""
htmlString = try decoder.decode(HTMLString.self, from: Data(alreadyEncodedLink.utf8))
XCTAssertEqual("This is a test", htmlString.asRawText)
XCTAssertEqual("<p>This is a <a href=\"https://test.com/go%C3%9F%C3%AB%C3%B1a\">test</a></p>", htmlString.htmlValue)
XCTAssertEqual("This is a [test](https://test.com/go%C3%9F%C3%AB%C3%B1a)", htmlString.asMarkdown)
XCTAssertEqual(0, htmlString.statusesURLs.count)
XCTAssertEqual(1, htmlString.links.count)
XCTAssertEqual("https://test.com/go%C3%9F%C3%AB%C3%B1a", htmlString.links[0].url.absoluteString)
XCTAssertEqual("test", htmlString.links[0].displayString)
}
Swiftformat
2023-09-16 12:15:03 +00:00
Bugfix 1459 - Escape ~ character as markdown (#1561) * Add simple test for escaping markdown content in statuses * Add ~ as markdown character to be escaped in statuses The ~ isn't documented in the original markdown syntax docs but is commonly used (including by AttributedString) to surround text formatted with a strikethrough.
2023-08-24 07:58:29 +00:00
func testHTMLStringInit_markdownEscaping() throws {
let decoder = JSONDecoder()
Swiftformat
2023-09-16 12:15:03 +00:00
Bugfix 1459 - Escape ~ character as markdown (#1561) * Add simple test for escaping markdown content in statuses * Add ~ as markdown character to be escaped in statuses The ~ isn't documented in the original markdown syntax docs but is commonly used (including by AttributedString) to surround text formatted with a strikethrough.
2023-08-24 07:58:29 +00:00
let stdMarkdownContent = "\"<p>This [*is*] `a`\\n**test**</p>\""
var htmlString = try decoder.decode(HTMLString.self, from: Data(stdMarkdownContent.utf8))
XCTAssertEqual("This [*is*] `a`\n**test**", htmlString.asRawText)
XCTAssertEqual("<p>This [*is*] `a`\n**test**</p>", htmlString.htmlValue)
XCTAssertEqual("This \\[\\*is\\*] \\`a\\` \\*\\*test\\*\\*", htmlString.asMarkdown)
Swiftformat
2023-09-16 12:15:03 +00:00
Bugfix 1459 - Escape ~ character as markdown (#1561) * Add simple test for escaping markdown content in statuses * Add ~ as markdown character to be escaped in statuses The ~ isn't documented in the original markdown syntax docs but is commonly used (including by AttributedString) to surround text formatted with a strikethrough.
2023-08-24 07:58:29 +00:00
let underscoreContent = "\"<p>This _is_ an :emoji_maybe:</p>\""
htmlString = try decoder.decode(HTMLString.self, from: Data(underscoreContent.utf8))
XCTAssertEqual("This _is_ an :emoji_maybe:", htmlString.asRawText)
XCTAssertEqual("<p>This _is_ an :emoji_maybe:</p>", htmlString.htmlValue)
XCTAssertEqual("This \\_is\\_ an :emoji_maybe:", htmlString.asMarkdown)
let strikeContent = "\"<p>This ~is~ a\\n`test`</p>\""
htmlString = try decoder.decode(HTMLString.self, from: Data(strikeContent.utf8))
XCTAssertEqual("This ~is~ a\n`test`", htmlString.asRawText)
XCTAssertEqual("<p>This ~is~ a\n`test`</p>", htmlString.htmlValue)
XCTAssertEqual("This \\~is\\~ a \\`test\\`", htmlString.asMarkdown)
}
Support status links with non-ASCII characters (Bugfix 1546) (#1550) * Allow creation of URL objects from strings containing non-ASCII characters Adds a new initializer for creating URL objects with a flag to specify that non-ASCII characters found in the path or query string should first be URL encoded. * Add basic test for creating HTMLString objects * Encode link paths and queries when parsing statuses It's common to use non-ASCII characters in URLs even though they're technically invalid characters. Every modern browser handles this by silently encoding the invalid characters on the user's behalf. However, trying to create a URL object with un-encoded characters will result in nil so we need to encode the invalid characters before creating the URL object. The unencoded version should still be shown in the displayed status. The parsing of the URL string is a little messy because we can't use the URL class for this scenario and need to duplicate some of its work. * Only encode link URLs as a backup If a URL can be created from a status href, don't try URL encoding it as this could result in double encoding. Only encode the string if the creation of a URL fails. This is also more efficient.
2023-08-23 05:08:12 +00:00
}
Reference in a new issue Copy permalink