From 7c38c0a4d6375794d31eaf6869807c6c5356063e Mon Sep 17 00:00:00 2001
From: silverpill <silverpill@firemail.cc>
Date: Thu, 6 Apr 2023 15:39:23 +0000
Subject: [PATCH] Increase object ID size limit to 2000 chars

---
 CHANGELOG.md                                         |  1 +
 .../migrations/V0052__post__object_id_length.sql     |  6 ++++++
 mitra-models/migrations/schema.sql                   | 12 ++++++------
 src/validators/posts.rs                              |  2 +-
 4 files changed, 14 insertions(+), 7 deletions(-)
 create mode 100644 mitra-models/migrations/V0052__post__object_id_length.sql

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c06258a..16e0dc4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Validate actor aliases before saving into database.
 - Process incoming `Move()` activities in background.
 - Allow custom emojis with `image/webp` media type.
+- Increase object ID size limit to 2000 chars.
 
 ### Fixed
 
diff --git a/mitra-models/migrations/V0052__post__object_id_length.sql b/mitra-models/migrations/V0052__post__object_id_length.sql
new file mode 100644
index 0000000..80b8a3d
--- /dev/null
+++ b/mitra-models/migrations/V0052__post__object_id_length.sql
@@ -0,0 +1,6 @@
+ALTER TABLE actor_profile ALTER COLUMN actor_id TYPE VARCHAR(2000);
+ALTER TABLE oauth_application ALTER COLUMN redirect_uri TYPE VARCHAR(2000);
+ALTER TABLE follow_request ALTER COLUMN activity_id TYPE VARCHAR(2000);
+ALTER TABLE post ALTER COLUMN object_id TYPE VARCHAR(2000);
+ALTER TABLE post_reaction ALTER COLUMN activity_id TYPE VARCHAR(2000);
+ALTER TABLE emoji ALTER COLUMN object_id TYPE VARCHAR(2000);
diff --git a/mitra-models/migrations/schema.sql b/mitra-models/migrations/schema.sql
index 8839db7..e616573 100644
--- a/mitra-models/migrations/schema.sql
+++ b/mitra-models/migrations/schema.sql
@@ -37,7 +37,7 @@ CREATE TABLE actor_profile (
     post_count INTEGER NOT NULL CHECK (post_count >= 0) DEFAULT 0,
     emojis JSONB NOT NULL DEFAULT '[]',
     actor_json JSONB,
-    actor_id VARCHAR(200) UNIQUE GENERATED ALWAYS AS (actor_json ->> 'id') STORED,
+    actor_id VARCHAR(2000) UNIQUE GENERATED ALWAYS AS (actor_json ->> 'id') STORED,
     created_at TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(),
     updated_at TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT CURRENT_TIMESTAMP,
     unreachable_since TIMESTAMP WITH TIME ZONE,
@@ -66,7 +66,7 @@ CREATE TABLE oauth_application (
     app_name VARCHAR(100) NOT NULL,
     website VARCHAR(100),
     scopes VARCHAR(200) NOT NULL,
-    redirect_uri VARCHAR(200) NOT NULL,
+    redirect_uri VARCHAR(2000) NOT NULL,
     client_id UUID UNIQUE NOT NULL,
     client_secret VARCHAR(100) NOT NULL,
     created_at TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT CURRENT_TIMESTAMP
@@ -103,7 +103,7 @@ CREATE TABLE follow_request (
     id UUID PRIMARY KEY,
     source_id UUID NOT NULL REFERENCES actor_profile (id) ON DELETE CASCADE,
     target_id UUID NOT NULL REFERENCES actor_profile (id) ON DELETE CASCADE,
-    activity_id VARCHAR(250) UNIQUE,
+    activity_id VARCHAR(2000) UNIQUE,
     request_status SMALLINT NOT NULL,
     UNIQUE (source_id, target_id),
     CHECK (source_id != target_id)
@@ -119,7 +119,7 @@ CREATE TABLE post (
     reply_count INTEGER NOT NULL CHECK (reply_count >= 0) DEFAULT 0,
     reaction_count INTEGER NOT NULL CHECK (reaction_count >= 0) DEFAULT 0,
     repost_count INTEGER NOT NULL CHECK (repost_count >= 0) DEFAULT 0,
-    object_id VARCHAR(200) UNIQUE,
+    object_id VARCHAR(2000) UNIQUE,
     ipfs_cid VARCHAR(200),
     token_id INTEGER,
     token_tx_id VARCHAR(200),
@@ -132,7 +132,7 @@ CREATE TABLE post_reaction (
     id UUID PRIMARY KEY,
     author_id UUID NOT NULL REFERENCES actor_profile (id) ON DELETE CASCADE,
     post_id UUID NOT NULL REFERENCES post (id) ON DELETE CASCADE,
-    activity_id VARCHAR(250) UNIQUE,
+    activity_id VARCHAR(2000) UNIQUE,
     created_at TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT now(),
     UNIQUE (author_id, post_id)
 );
@@ -177,7 +177,7 @@ CREATE TABLE emoji (
     emoji_name VARCHAR(100) NOT NULL,
     hostname VARCHAR(100) REFERENCES instance (hostname) ON DELETE RESTRICT,
     image JSONB NOT NULL,
-    object_id VARCHAR(250) UNIQUE,
+    object_id VARCHAR(2000) UNIQUE,
     updated_at TIMESTAMP WITH TIME ZONE NOT NULL,
     UNIQUE (emoji_name, hostname),
     CHECK ((hostname IS NULL) = (object_id IS NULL))
diff --git a/src/validators/posts.rs b/src/validators/posts.rs
index 47c4ad9..7ed3458 100644
--- a/src/validators/posts.rs
+++ b/src/validators/posts.rs
@@ -7,7 +7,7 @@ pub const MENTIONS_MAX_NUM: usize = 50;
 pub const LINKS_MAX_NUM: usize = 10;
 pub const EMOJIS_MAX_NUM: usize = 50;
 
-pub const OBJECT_ID_SIZE_MAX: usize = 200;
+pub const OBJECT_ID_SIZE_MAX: usize = 2000;
 pub const CONTENT_MAX_SIZE: usize = 100000;
 const CONTENT_ALLOWED_TAGS: [&str; 8] = [
     "a",